Configuration Source Extraction part 4/5 - Integrate Default HTTP Client #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2026
typotter
changed the title
typotter
force-pushed
the
typo/integrate-http-client
branch
from
06e48a0 to
3959bd1
Compare
typotter
changed the title
This was referenced Jan 23, 2026
typotter
changed the title
typotter
force-pushed
the
typo/flag-source-interface
branch
from
32638b2 to
5644864
Compare
typotter
force-pushed
the
typo/integrate-http-client
branch
from
9fbd452 to
5c94b16
Compare
Introduces a new default HTTP client for fetching Eppo configuration that uses OkHttp and Jackson with EppoModule for JSON parsing. Key features: - Async-only methods returning CompletableFuture - ETag support via If-None-Match header for conditional requests - 10-second timeouts for HTTP operations - Type-safe responses with parsed configuration objects - API key redaction in error messages - Comprehensive error handling (200, 304, 403, 500) This implementation is standalone and does not yet integrate with the existing codebase. Integration will come in a follow-up PR. Also includes: - Comprehensive unit tests using MockWebServer - Tests for ConfigurationRequest, ConfigurationResponse, and ConfigurationRequestFactory - Fix for import in ConfigurationRequestFactory
This commit completes the integration of the new HTTP client: Core integration changes: - Update IEppoConfigurationHttpClient to async-only (remove sync methods) - Update Configuration.Builder to accept IFlagConfigResponse and IBanditParametersResponse directly - Add endpoint-specific methods to ConfigurationRequestFactory - Update ConfigurationRequestor to use new client interface with ConfigurationResponse handling - Update BaseEppoClient to use DefaultEppoConfigurationHttpClient Removed legacy code: - EppoHttpClient.java - EppoHttpClientRequestCallback.java - EppoHttpClientTest.java Test updates: - Update ConfigurationRequestorTest with new mocking strategy - Update BaseEppoClientTest for new client interface - Update TestUtils helper methods for IEppoConfigurationHttpClient All 279+ tests pass successfully.
typotter
force-pushed
the
typo/integrate-http-client
branch
from
5c94b16 to
a5cbd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration Source Extraction part 4/5 - Integrate Default HTTP Client
🥞 Configuration Refactor Stacked Pull Requests 🥞
🔲 Make HTTP client injectable via constructor (#207)
👉 Integrate default HTTP client implementation (this PR)
✅ Add configuration HTTP client interface (#205)
✅ Add flagsSnapshotId field to Configuration (#208)
✅ Extract DTO interfaces for downstream SDK extensibility (#197)
⬇️
feature/v4(trunk)Motivation and Context
PR #205 extracted the
IEppoConfigurationHttpClientinterface, but without a concrete implementation, the SDK cannot actually fetch configurations.This PR provides a default implementation using OkHttp that:
DefaultEppoConfigurationHttpClientclassConfigurationRequestorseamlesslyThis allows the SDK to continue working out-of-the-box while enabling downstream SDKs to provide alternative implementations.
Description
Create
DefaultEppoConfigurationHttpClient- an OkHttp-based implementation ofIEppoConfigurationHttpClientand integrate it into the existing codebase.Implementation Details
DefaultEppoConfigurationHttpClient:Callfor HTTP requestsObjectMapperfor JSON deserializationIntegration Changes
ConfigurationRequestor:IEppoConfigurationHttpClientin constructorEppoHttpClientcallsBaseEppoClient:DefaultEppoConfigurationHttpClientinstanceConfigurationRequestorHow has this been documented?
DefaultEppoConfigurationHttpClientHow has this been tested?
Breaking Changes
None. The SDK continues to work exactly as before, using the default OkHttp-based implementation.
Dependencies
Depends on: PR #205 (typo/flag-source-interface)
Blocks: PR #207