-
Notifications
You must be signed in to change notification settings - Fork 1
Configuration Source Extraction part 3/5 - Add Configuration HTTP Client Interface #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
typotter
wants to merge
4
commits into
typo/etag-in-configuration
Choose a base branch
from
typo/flag-source-interface
base: typo/etag-in-configuration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f989187 to
92d52f7
Compare
typotter
commented
Jan 21, 2026
| import cloud.eppo.api.IFlagConfigResponse; | ||
| import java.util.concurrent.CompletableFuture; | ||
|
|
||
| public interface IEppoConfigurationHttpClient { |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Nullable param to be added to
initand constructor forEppoClient - Default implementation will use OkHttp & sdk-specific json parsing util.
- Implementations are responsible for network requests and parsing responses.
typotter
commented
Jan 21, 2026
|
|
||
| public interface IEppoConfigurationHttpClient { | ||
|
|
||
| <T extends IFlagConfigResponse> ConfigurationResponse<IFlagConfigResponse> fetchFlagConfiguration( |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IFlagConfigResponse and IBanditParametersResponse are interfaces all the way down
This was referenced Jan 23, 2026
32638b2 to
5644864
Compare
f8eeae5 to
fac2c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration Source Extraction part 3/5 - Add Configuration HTTP Client Interface
🥞 Configuration Refactor Stacked Pull Requests 🥞
🔲 Make HTTP client injectable via constructor (#207)
🔲 Integrate default HTTP client implementation (#206)
👉 Add configuration HTTP client interface (this PR)
✅ Add flagsSnapshotId field to Configuration (#208)
✅ Extract DTO interfaces for downstream SDK extensibility (#197)
⬇️
feature/v4(trunk)Motivation and Context
Building on the DTO interface extraction (#197) and the flagsSnapshotId field addition (#208), we need to provide an interface for configuration fetching that allows downstream SDKs to:
The current tight coupling to
EppoHttpClient(OkHttp-based) prevents this flexibility.Description
Extract
IEppoConfigurationHttpClientinterface and supporting request/response classes to enable pluggable HTTP client implementations.New Classes Added
IEppoConfigurationHttpClient- Interface for HTTP configuration fetchingConfigurationResponse<T>wrapperConfigurationRequest- Request data classConfigurationResponse<T>- Generic response wrapperFlags.success(),Bandits.notModified(), etc.isSuccess(),isNotModified(),isError()ConfigurationRequestFactory- Factory for creating requestsTests Added
ConfigurationRequestTest(4 tests) - Request creation and validationConfigurationResponseTest(18 tests) - Response factory methods, status checksConfigurationRequestFactoryTest(8 tests) - Request factory behaviorTotal: 30 new tests ensuring robust API contracts.
How has this been documented?
How has this been tested?
Breaking Changes
None. This PR only adds new classes without modifying existing behavior.
Dependencies
Depends on: PR #208 (typo/etag-in-configuration)
Blocks: PRs #206, #207