Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit tag format when rebuilding docker containers #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update commit tag format when rebuilding docker containers #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cicd/gitlab/dot.gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ include:
# Genomio docker deploy (on release tag creation)
- local: cicd/gitlab/parts/dockerbuild.genomio.gitlab-ci.yml
rules:
- if: '$CI_COMMIT_TAG =~ /v[0-9]+\.[0-9]+\.[0-9]+$/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im pretty sure we need to base tag as we need this to run when we create a standard release via merge to main + create a new release tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On closer inspection, the rebuild portion of this tag can be present or absent right. If so disregard first comment :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new regex should cover both cases (the _rebuild_[az] is surrounded by a ?). If it is not too clear, happy to divide it in two as it was before.

when: always
- if: '$CI_COMMIT_TAG =~ /GenomioDockerRebuild_v[0-9]+\.[0-9]+\.[0-9]+[a-z]$/'
- if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+[ab]?(_rebuild_[a-z])?$/'
when: always


Expand Down