Update commit tag format when rebuilding docker containers #457
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,9 +52,7 @@ include: | |||
| # Genomio docker deploy (on release tag creation) | |||
| - local: cicd/gitlab/parts/dockerbuild.genomio.gitlab-ci.yml | |||
| rules: | |||
| - if: '$CI_COMMIT_TAG =~ /v[0-9]+\.[0-9]+\.[0-9]+$/' | |||
There was a problem hiding this comment.
Im pretty sure we need to base tag as we need this to run when we create a standard release via merge to main + create a new release tag
There was a problem hiding this comment.
On closer inspection, the rebuild portion of this tag can be present or absent right. If so disregard first comment :)
There was a problem hiding this comment.
The new regex should cover both cases (the _rebuild_[az] is surrounded by a ?). If it is not too clear, happy to divide it in two as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format will be, for instance,
v1.5.0_rebuild_a, which is shorter and starts with the version for better tracking.