Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front-end] Add ApplyFilters component and integrate into filter Panel #88

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

ms0ur1s
Copy link
Contributor

@ms0ur1s ms0ur1s commented Nov 22, 2024

What? Why?

Mobile view

On the search screen the apply filters box was layered on to of the navigation

Related to issue #66

  • Moved the apply filters box from the SearchPanel component to it's own ApplyFilters component.
  • Added the ApplyFilters component to the Panel component
  • Removed any related logic from the SearchPanel component and added it to the Panel component
  • Tested across Andriod and IOS mobile devices

Checklist

  • Updated or added any necessary docs in docs/
  • Added UTs
  • Checked that all automated tests pass

What should we test? (for QA)

Using a mobile device of browserstack:

  • Check that the apply filters box no longer appears on top of the navigation
  • Check that the apply filters button still functions correctly

@ms0ur1s ms0ur1s requested a review from rogup November 22, 2024 13:31
@ms0ur1s ms0ur1s mentioned this pull request Nov 22, 2024
4 tasks
@rogup rogup changed the base branch from main to dev November 22, 2024 15:09
@rogup rogup force-pushed the apply-filters-button branch 2 times, most recently from 7b2d500 to 6a8a206 Compare November 22, 2024 17:15
@rogup rogup force-pushed the apply-filters-button branch from 6a8a206 to 1cc465b Compare November 22, 2024 17:19
@rogup
Copy link
Contributor

rogup commented Nov 22, 2024

@ms0ur1s Nice work on this, it's looking great when I test it on my phone connected by USB :)

I added a slight fix for some funny behaviour due to the different uses of setText and setCurrentText

And also ended up accidentally adding other fixes to this branch, but it's fine since they're in separate commits. Will merge it all now

@rogup rogup merged commit df4a89a into dev Nov 22, 2024
1 check passed
@rogup rogup deleted the apply-filters-button branch November 22, 2024 17:21
@ms0ur1s
Copy link
Contributor Author

ms0ur1s commented Nov 22, 2024

@ms0ur1s Nice work on this, it's looking great when I test it on my phone connected by USB :)

I added a slight fix for some funny behaviour due to the different uses of setText and setCurrentText

And also ended up accidentally adding other fixes to this branch, but it's fine since they're in separate commits. Will merge it all now

Thanks man ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants