-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWM] Critical mobile UX bugs #66
Comments
Task 1: Added 80px padding to the bottom on the content panel (height of the nav), This bug only appears on my phone and I can't recreate it on my machine using dev tools or the browser plugin I have, so it needs live testing. Task 2: Reduced mobile pop-up height from 500px to 450px. PR for the first three issues |
Can I confirm this has been deployed? Still seeing these issues on my phone :( |
Yes, deployed. I'm seeing the changes live - mabybe some browser caching on your end? |
Popups behaving worse on my mobile now. Always some parts offscreen, and if I attempt to pan the map, they disappear. I am on a Galaxy S8. |
@ColmDC I can't repro this. Maybe it was due to the confusion of the earlier deploy not having updated code. Is it still happening for you, and in what location on the map? |
I take back statement about behaving worse. There are so many cases. So don't consider this a regression. I think making it possilbe for the user to pan to bring the popup into full view themselves will mean they can always see the data. In element I made the suggestion "I'm wondering if we can disable the popup disappearing when panning, as when it does clip, the user can at least manually move the popup into view?" But I know that behaviour was introduced to solve #78 Rohit suggested then that "Maybe it could temporarily be hidden whilst the map is being panned and then be reshown". This might work as long as it didn't then attempt to recentre once enabled again. |
Descriptions
In initial mobile testing a number of critical UX issues have come up. These all need fixing.
Acceptance Criteria
The above issues are fixed and deployed.
The text was updated successfully, but these errors were encountered: