Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWM] Critical mobile UX bugs #66

Closed
4 tasks done
lin-d-hop opened this issue Nov 20, 2024 · 13 comments
Closed
4 tasks done

[CWM] Critical mobile UX bugs #66

lin-d-hop opened this issue Nov 20, 2024 · 13 comments
Assignees
Labels

Comments

@lin-d-hop
Copy link

lin-d-hop commented Nov 20, 2024

Descriptions

In initial mobile testing a number of critical UX issues have come up. These all need fixing.

  • Directory, Search and results don't scroll up quite far enough, leaving some content behind the nav
  • Pop-up doesn't fit on the screen well, resulting in weird behaviour and a difficulty to view it, particularly on smaller screens
  • Add apply filter button and don't open the results panel until this is clicked. The UX on this needs to be clear ie dont make it so you ahve to scroll to see the button.
  • Search results not closing when result is clicked (doing this in [CWM] Centre map position to marker on click (marker or result) #64)

Acceptance Criteria

The above issues are fixed and deployed.

@ms0ur1s
Copy link
Contributor

ms0ur1s commented Nov 20, 2024

Task 1: Added 80px padding to the bottom on the content panel (height of the nav), This bug only appears on my phone and I can't recreate it on my machine using dev tools or the browser plugin I have, so it needs live testing.

Task 2: Reduced mobile pop-up height from 500px to 450px.

PR for the first three issues

#73

@rogup
Copy link
Contributor

rogup commented Nov 20, 2024

@ms0ur1s I'll take task 4 and do it as part of my work on #64

@lin-d-hop
Copy link
Author

Guys! Impressive!
@rogup @ms0ur1s

@lin-d-hop
Copy link
Author

Can I confirm this has been deployed? Still seeing these issues on my phone :(

@ms0ur1s
Copy link
Contributor

ms0ur1s commented Nov 21, 2024

@ms0ur1s I'll take task 4 and do it as part of my work on #64

Thanks man ❤

@rogup
Copy link
Contributor

rogup commented Nov 21, 2024

Can I confirm this has been deployed? Still seeing these issues on my phone :(

Yes, deployed. I'm seeing the changes live - mabybe some browser caching on your end?

@ms0ur1s
Copy link
Contributor

ms0ur1s commented Nov 21, 2024

Andriod and IOS positional difference for reference

Android Chrome

Image

IOS Safari

Image

IOS Chrome

Image

@ms0ur1s
Copy link
Contributor

ms0ur1s commented Nov 22, 2024

@ColmDC
Copy link

ColmDC commented Nov 22, 2024

Popups behaving worse on my mobile now. Always some parts offscreen, and if I attempt to pan the map, they disappear. I am on a Galaxy S8.

@rogup
Copy link
Contributor

rogup commented Nov 22, 2024

@ColmDC I can't repro this. Maybe it was due to the confusion of the earlier deploy not having updated code. Is it still happening for you, and in what location on the map?

@ColmDC
Copy link

ColmDC commented Nov 23, 2024

I'm still seeing it on deploy-2024-11-19-41-g2e5b07b.

SmallScreen

@ColmDC
Copy link

ColmDC commented Nov 23, 2024

Popups behaving worse on my mobile now.

I take back statement about behaving worse. There are so many cases. So don't consider this a regression. I think making it possilbe for the user to pan to bring the popup into full view themselves will mean they can always see the data.

In element I made the suggestion

"I'm wondering if we can disable the popup disappearing when panning, as when it does clip, the user can at least manually move the popup into view?"

But I know that behaviour was introduced to solve #78

Rohit suggested then that "Maybe it could temporarily be hidden whilst the map is being panned and then be reshown". This might work as long as it didn't then attempt to recentre once enabled again.

@ColmDC
Copy link

ColmDC commented Dec 4, 2024

#78 (comment)

@ColmDC ColmDC closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants