-
Notifications
You must be signed in to change notification settings - Fork 2
Add snapshot plan #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 12 24 +12
=========================================
+ Hits 12 24 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there a good example of the kind of test I should add for this? |
callumforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GDYendell this looks good, I think it's worth having a plan that takes a snapshot of the whole beamline like this. I should probably adapt #3 to fit in with it.
07dbda4 to
0ba9299
Compare
|
I think I have resolved all comments except the numtracker one |
callumforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.