Skip to content

Conversation

@GDYendell
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7f942a9) to head (9bd5f8f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           12        24   +12     
=========================================
+ Hits            12        24   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell
Copy link
Contributor Author

Is there a good example of the kind of test I should add for this?

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GDYendell this looks good, I think it's worth having a plan that takes a snapshot of the whole beamline like this. I should probably adapt #3 to fit in with it.

@callumforrester callumforrester mentioned this pull request Jul 8, 2025
@GDYendell GDYendell force-pushed the snapshot-plan branch 2 times, most recently from 07dbda4 to 0ba9299 Compare July 8, 2025 13:36
GDYendell added 2 commits July 8, 2025 13:37
The system tests fail because of this
@GDYendell
Copy link
Contributor Author

I think I have resolved all comments except the numtracker one

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GDYendell GDYendell merged commit f082a8a into main Jul 8, 2025
8 checks passed
@callumforrester callumforrester deleted the snapshot-plan branch July 8, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants