-
Notifications
You must be signed in to change notification settings - Fork 2
Create system test #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 12 12
=========================================
Hits 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efeb811 to
0f1d0de
Compare
0d6dd8b to
7e8683e
Compare
GDYendell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Spotted some typos. Couple of questions to make sure I understand what this is doing.
bff693c to
daab6b3
Compare
daab6b3 to
219b7af
Compare
|
@GDYendell any strong opinions on squash merge/rebase merge for this repo, I'm easy. I also got rid of the empty |
|
These commits are neat so I would do a merge commit, but in general I don't mind using squash commits if we want it to be consistent if it means not merging review change commits. |
Create system test proving that blueapi and the nexus writer work as expected