Skip to content

Conversation

@callumforrester
Copy link
Contributor

@callumforrester callumforrester commented Jul 1, 2025

Create system test proving that blueapi and the nexus writer work as expected

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fe7e3d7) to head (219b7af).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           12        12           
=========================================
  Hits            12        12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@callumforrester callumforrester changed the title Create plan that collects dummy data Create system test Jul 4, 2025
@callumforrester callumforrester force-pushed the dummy-data branch 2 times, most recently from 0d6dd8b to 7e8683e Compare July 4, 2025 16:10
@callumforrester callumforrester marked this pull request as ready for review July 7, 2025 09:31
@callumforrester callumforrester mentioned this pull request Jul 7, 2025
@callumforrester callumforrester requested a review from GDYendell July 7, 2025 09:38
Copy link
Contributor

@GDYendell GDYendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Spotted some typos. Couple of questions to make sure I understand what this is doing.

@callumforrester
Copy link
Contributor Author

@GDYendell any strong opinions on squash merge/rebase merge for this repo, I'm easy.

I also got rid of the empty plans/__init__.py file, which was a vestige of a previous version, this can be replaced by your changes in #4

@GDYendell
Copy link
Contributor

GDYendell commented Jul 8, 2025

These commits are neat so I would do a merge commit, but in general I don't mind using squash commits if we want it to be consistent if it means not merging review change commits.

@callumforrester callumforrester merged commit 7f942a9 into main Jul 8, 2025
8 checks passed
@callumforrester callumforrester deleted the dummy-data branch July 8, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants