This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Fix empty owners-to-ping in staleness comments #439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by a trivial cosmetic glitch (spurious
/
) in theUnmerged:nearly
comment:It was introduced in a change that instead targeted this
Unreviewed:
comment.The fix proposed here is, don't filter existing approvals out of
Unreviewed:
(andUnmerged:
) pings. Instead, don't apply the unreviewed label/timeline to PRs that have reviews and are already in the maintainer queue.The unreviewed timeline has two functions, I think:
It doesn't have a function if a PR in the maintainer queue has reviews?
The code already treats "unreviewed" as completely unreviewed vs. unreviewed by maintainers, I think:
dt-mergebot/src/comments.ts
Line 181 in 36ec63f
dt-mergebot/src/comments.ts
Line 185 in 36ec63f
This change:
Unmerged:
andUnreviewed:
comments).