Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Commit

Permalink
Improve PingReviewersOther
Browse files Browse the repository at this point in the history
Don't say that "you're the only owner" if the author is not an existing
owner or a new one.
  • Loading branch information
elibarzilay committed Sep 17, 2021
1 parent cac40d9 commit 36ec63f
Show file tree
Hide file tree
Showing 20 changed files with 426 additions and 12 deletions.
2 changes: 1 addition & 1 deletion src/_tests/fixtures/45946/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0NDQ2MDIxMjkw",
"body": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
"body": "🔔 @rubensworks — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/45946/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @rubensworks — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @rubensworks — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45946/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
}
],
"shouldClose": false,
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/49575/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0NTIxMTM3NjEy",
"body": "🔔 @jablko — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
"body": "🔔 @jablko — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/49575/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @jablko — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @jablko — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49575/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
},
{
"tag": "stale-ping-d2e897-6400f4c",
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/49841/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"variables": {
"input": {
"subjectId": "MDExOlB1bGxSZXF1ZXN0NTI4OTE2Mjg5",
"body": "🔔 @shekari-ah — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
"body": "🔔 @shekari-ah — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/49841/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @shekari-ah — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @shekari-ah — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49841/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
},
{
"tag": "gh-actions-complaint-4849e88",
Expand Down
9 changes: 9 additions & 0 deletions src/_tests/fixtures/50429/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
"input": {
"id": "MDEyOklzc3VlQ29tbWVudDc1NTI4NDk4Mg==",
"body": "🔔 @SaltyAom — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50429/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
},
{
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/50429/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @SaltyAom — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50429/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @SaltyAom — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/50429/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
},
{
"tag": "gh-actions-complaint-8454d08",
Expand Down
9 changes: 9 additions & 0 deletions src/_tests/fixtures/52579-edits-infra/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,14 @@
"labelableId": "MDExOlB1bGxSZXF1ZXN0NjIyODUxNTk2"
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
"input": {
"id": "MDEyOklzc3VlQ29tbWVudDgyNjM5OTk3MA==",
"body": "🔔 @Phong6698 — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52579/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
}
]
2 changes: 1 addition & 1 deletion src/_tests/fixtures/52579-edits-infra/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @Phong6698 — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52579/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @Phong6698 — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52579/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
}
],
"shouldClose": false,
Expand Down
9 changes: 9 additions & 0 deletions src/_tests/fixtures/52848/mutations.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@
}
}
},
{
"mutation": "mutation ($input: UpdateIssueCommentInput!) {\n updateIssueComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
"input": {
"id": "MDEyOklzc3VlQ29tbWVudDgzNjMyOTAwMg==",
"body": "🔔 @Runtu4378 — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52848/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
}
}
},
{
"mutation": "mutation ($input: AddCommentInput!) {\n addComment(input: $input) {\n __typename\n }\n}\n",
"variables": {
Expand Down
2 changes: 1 addition & 1 deletion src/_tests/fixtures/52848/result.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
{
"tag": "pinging-reviewers-others",
"status": "🔔 @Runtu4378 — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52848/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
"status": "🔔 @Runtu4378 — there are no owners, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52848/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
},
{
"tag": "merge-offer",
Expand Down
3 changes: 3 additions & 0 deletions src/_tests/fixtures/55741/_downloads.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ax": 0
}
5 changes: 5 additions & 0 deletions src/_tests/fixtures/55741/_files.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"aded751196aea4180928204085f088eb530d7b88:types/ax/tsconfig.json": "{\n \"compilerOptions\": {\n \"module\": \"commonjs\",\n \"lib\": [\n \"es6\"\n ],\n \"noImplicitAny\": true,\n \"noImplicitThis\": true,\n \"strictFunctionTypes\": true,\n \"strictNullChecks\": true,\n \"baseUrl\": \"../\",\n \"typeRoots\": [\n \"../\"\n ],\n \"types\": [],\n \"noEmit\": true,\n \"forceConsistentCasingInFileNames\": true\n },\n \"files\": [\n \"index.d.ts\",\n \"ax-tests.ts\"\n ]\n}\n",
"aded751196aea4180928204085f088eb530d7b88:types/ax/tslint.json": "{ \"extends\": \"dtslint/dt.json\" }\n",
"aded751196aea4180928204085f088eb530d7b88:types/ax/index.d.ts": "// Type definitions for ax 0.1\n// Project: https://github.com/AstroxNetwork/ax\n// Definitions by: Hsehoiki <https://github.com/AstroxNetwork>\n// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n\ninterface AxType {\n /**\n * ax function\n */\n setNavigationBarTitle: (text: string) => boolean;\n setNavigationBarColor: (color: string) => boolean;\n}\n\n/**\n * ax is global object\n */\ndeclare const ax: AxType;\n\nexport = ax;\n"
}
Loading

0 comments on commit 36ec63f

Please sign in to comment.