Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Investigate crashes at startup #9869

Closed
wants to merge 51 commits into from

Conversation

cbeauchesne
Copy link
Contributor

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/crash-investigation branch from 67cbbe7 to f67db92 Compare July 18, 2024 12:05
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/crash-investigation branch from f67db92 to 0f95e05 Compare July 18, 2024 12:29
@cbeauchesne cbeauchesne reopened this Jul 18, 2024
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jul 18, 2024

Library Vulnerabilities

Critical badge  High badge  Medium badge

@cbeauchesne cbeauchesne force-pushed the cbeauchesne/crash-investigation branch from b248ab9 to ec25e37 Compare July 18, 2024 17:18
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/crash-investigation branch from ec25e37 to 37085c7 Compare July 18, 2024 17:20
cbeauchesne and others added 6 commits July 19, 2024 10:02
…estigation

# Conflicts:
#	.github/workflows/requirements-locks.yml
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jul 24, 2024

Datadog Report

Branch report: cbeauchesne/crash-investigation
Commit report: 5f2688a
Test service: dd-trace-py

❌ 11 Failed (0 Known Flaky), 109790 Passed, 3911 Skipped, 6m 12.64s Total duration (7m 18s time saved)

❌ Failed Tests (11)

This report shows up to 5 failed tests.

  • test_ddtrace_iast_flask_app_create_app_patch_all_enable_iast_propagation - test_flask_entrypoint_iast_patches.py - Details

    Expand for error
     Expected status 0, got 1.
     === Captured STDOUT ===
     === End of captured STDOUT ===
     === Captured STDERR ===
     Traceback (most recent call last):
       File "tests/appsec/integrations/test_flask_entrypoint_iast_patches.py", line 173, in <module>
         assert "(add_aspect)" in str_output
     AssertionError
     === End of captured STDERR ===
    
  • test_ddtrace_iast_flask_app_create_app_patch_all_enable_iast_propagation - test_flask_entrypoint_iast_patches.py

  • test_ddtrace_iast_flask_app_create_app_patch_all_enable_iast_propagation - test_flask_entrypoint_iast_patches.py - Details

    Expand for error
     Expected status 0, got 1.
     === Captured STDOUT ===
     === End of captured STDOUT ===
     === Captured STDERR ===
     Traceback (most recent call last):
       File "tests/appsec/integrations/test_flask_entrypoint_iast_patches.py", line 173, in <module>
         assert "(add_aspect)" in str_output
     AssertionError
     === End of captured STDERR ===
    
  • test_ddtrace_iast_flask_app_create_app_patch_all_enable_iast_propagation - test_flask_entrypoint_iast_patches.py - Details

    Expand for error
     Expected status 0, got 1.
     === Captured STDOUT ===
     === End of captured STDOUT ===
     === Captured STDERR ===
     Traceback (most recent call last):
       File "tests/appsec/integrations/test_flask_entrypoint_iast_patches.py", line 173, in <module>
         assert "(add_aspect)" in str_output
     AssertionError
     === End of captured STDERR ===
    
  • test_ddtrace_iast_flask_app_create_app_patch_all_enable_iast_propagation - test_flask_entrypoint_iast_patches.py - Details

    Expand for error
     Expected status 0, got 1.
     === Captured STDOUT ===
     === End of captured STDOUT ===
     === Captured STDERR ===
     Traceback (most recent call last):
       File "tests/appsec/integrations/test_flask_entrypoint_iast_patches.py", line 173, in <module>
         assert "(add_aspect)" in str_output
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     AssertionError
     === End of captured STDERR ===
    

@juanjux juanjux closed this Jul 24, 2024
@juanjux juanjux reopened this Jul 24, 2024
@juanjux juanjux closed this Jul 24, 2024
@juanjux juanjux reopened this Jul 24, 2024
Signed-off-by: Juanjo Alvarez <[email protected]>
juanjux added 5 commits July 25, 2024 14:28
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 25, 2024
@juanjux juanjux reopened this Jul 25, 2024
@juanjux juanjux closed this Jul 26, 2024
@juanjux juanjux reopened this Jul 26, 2024
@juanjux juanjux closed this Jul 26, 2024
@juanjux juanjux reopened this Jul 26, 2024
@github-actions github-actions bot added the stale label Sep 25, 2024
Copy link
Contributor

This pull request has been automatically closed after a period of inactivity.
After this much time, it will likely be easier to open a new pull request with the
same changes than to update this one from the base branch. Please comment or reopen
if you think this pull request was closed in error.

@github-actions github-actions bot closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants