Skip to content

Commit

Permalink
chore: update returned line number in test (#9840)
Browse files Browse the repository at this point in the history
## Description

Since #8549 frames without a line number report the line number as `-1`.
This PR updates one test so it checks the correct value.

## Checklist
- [X] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Signed-off-by: Juanjo Alvarez <[email protected]>
  • Loading branch information
juanjux authored Jul 18, 2024
1 parent b729751 commit 0f95e05
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tests/appsec/iast_memcheck/test_iast_mem_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,5 +188,4 @@ def test_stacktrace_memory_random_string_check():

file_name, line_number = frame_info
assert file_name == ""
# FIXME: https://datadoghq.atlassian.net/browse/APPSEC-54114
# assert line_number == 0
assert line_number == -1

0 comments on commit 0f95e05

Please sign in to comment.