ci: have system-tests download from publicly published wheels#16576
ci: have system-tests download from publicly published wheels#16576brettlangdon wants to merge 1 commit intomainfrom
Conversation
brettlangdon
added
the
changelog/no-changelog
Codeowners resolved as |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afcf7e7ff6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| bash scripts/download-s3-wheels.sh \ | ||
| "${{ steps.resolve-sha.outputs.sha }}" \ | ||
| ./wheels \ | ||
| manylinux2014_x86_64 |
There was a problem hiding this comment.
The workflow now depends on scripts/download-s3-wheels.sh, but pull_request.paths-ignore still excludes scripts/**, so a PR that only changes this downloader can skip system-tests entirely. That creates a gap where regressions in the new wheel-fetch path can merge without being exercised by this workflow.
Useful? React with 👍 / 👎.
KowalskiThomas
left a comment
KowalskiThomas
left a comment
There was a problem hiding this comment.
Nice! Don't have time for review but this is exciting! 🤩
2 participants
Description
This PR changes system-tests to poll and download artifacts built from the GitLab job instead of rebuilding.
This should:
Testing
Risks
Additional Notes