Skip to content

Conversation

@aiuto
Copy link
Contributor

@aiuto aiuto commented Sep 22, 2025

  • Maintain our own copy of certs rather than downloading during the build
  • Include text in the BUILD file about how we check for new upstream versions.
  • Add explanation of why we have this.
  • Add tooling to install via //packags/install_dir/embedded:everything.
  • Not used yet to minimize rollback surface. The followup PR will put it in place.

Followup PR

  • Add to //packags/install_dir/embedded:everything.
  • Delete cacerts.rb

https://datadoghq.atlassian.net/browse/ABLD-169

@github-actions github-actions bot added long review PR is complex, plan time to review it team/agent-build labels Sep 22, 2025
@aiuto aiuto added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Sep 22, 2025
@aiuto aiuto force-pushed the aiuto/certs branch 2 times, most recently from 077c971 to 091620c Compare September 23, 2025 03:45
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Sep 23, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: cc5b02fc-9715-4bd5-a734-12e2c3f19740

Baseline: 3937bbf
Comparison: af13fbd
Diff

❌ Experiments with retried target crashes

This is a critical error. One or more replicates failed with a non-zero exit code. These replicates may have been retried. See Replicate Execution Details for more information.

  • quality_gate_idle_all_features

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.06 [-2.04, +4.17] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.87 [+1.37, +4.38] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +1.96 [+1.74, +2.17] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +1.06 [-2.04, +4.17] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.46 [+0.40, +0.51] 1 Logs
quality_gate_idle memory utilization +0.30 [+0.26, +0.34] 1 Logs bounds checks dashboard
file_tree memory utilization +0.16 [+0.11, +0.22] 1 Logs
docker_containers_memory memory utilization +0.09 [+0.02, +0.17] 1 Logs
ddot_metrics memory utilization +0.08 [-0.16, +0.32] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.35, +0.43] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.02, +0.06] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.12, +0.14] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.50, +0.51] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.12, +0.12] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.00 [-0.17, +0.17] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.44, +0.41] 1 Logs
otlp_ingest_logs memory utilization -0.07 [-0.17, +0.03] 1 Logs
ddot_logs memory utilization -0.20 [-0.26, -0.14] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.29 [-0.52, -0.06] 1 Logs
quality_gate_idle_all_features memory utilization -0.39 [-0.43, -0.35] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.42 [-0.57, -0.26] 1 Logs
ddot_metrics_sum_delta memory utilization -0.92 [-1.12, -0.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput -2.83 [-2.91, -2.75] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Replicate Execution Details

We run multiple replicates for each experiment/variant. However, we allow replicates to be automatically retried if there are any failures, up to 8 times, at which point the replicate is marked dead and we are unable to run analysis for the entire experiment. We call each of these attempts at running replicates a replicate execution. This section lists all replicate executions that failed due to the target crashing or being oom killed.

Note: In the below tables we bucket failures by experiment, variant, and failure type. For each of these buckets we list out the replicate indexes that failed with an annotation signifying how many times said replicate failed with the given failure mode. In the below example the baseline variant of the experiment named experiment_with_failures had two replicates that failed by oom kills. Replicate 0, which failed 8 executions, and replicate 1 which failed 6 executions, all with the same failure mode.

Experiment Variant Replicates Failure Logs Debug Dashboard
experiment_with_failures baseline 0 (x8) 1 (x6) Oom killed Debug Dashboard

The debug dashboard links will take you to a debugging dashboard specifically designed to investigate replicate execution failures.

❌ Retried Normal Replicate Execution Failures (non-profiling)

Experiment Variant Replicates Failure Debug Dashboard
quality_gate_idle_all_features comparison 1 Oom killed Debug Dashboard

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@aiuto aiuto force-pushed the aiuto/certs branch 2 times, most recently from 233a6d1 to e66deec Compare September 23, 2025 20:33
@aiuto aiuto marked this pull request as ready for review September 23, 2025 20:33
@aiuto aiuto requested a review from a team as a code owner September 23, 2025 20:33
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 23, 2025

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 3937bbf
📊 Static Quality Gates Dashboard

31 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 748.049 MiB
agent_deb_amd64_fips 708.157 MiB
agent_heroku_amd64 325.593 MiB
agent_msi 659.741 MiB
agent_rpm_amd64 748.033 MiB
agent_rpm_amd64_fips 708.141 MiB
agent_rpm_arm64 727.124 MiB
agent_rpm_arm64_fips 689.721 MiB
agent_suse_amd64 748.033 MiB
agent_suse_amd64_fips 708.141 MiB
agent_suse_arm64 727.124 MiB
agent_suse_arm64_fips 689.721 MiB
docker_agent_amd64 810.525 MiB
docker_agent_arm64 814.211 MiB
docker_agent_jmx_amd64 1001.403 MiB
docker_agent_jmx_arm64 993.809 MiB
docker_cluster_agent_amd64 180.824 MiB
docker_cluster_agent_arm64 196.669 MiB
docker_cws_instrumentation_amd64 7.135 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 38.414 MiB
docker_dogstatsd_arm64 36.749 MiB
dogstatsd_deb_amd64 29.630 MiB
dogstatsd_deb_arm64 27.802 MiB
dogstatsd_rpm_amd64 29.630 MiB
dogstatsd_suse_amd64 29.630 MiB
iot_agent_deb_amd64 42.751 MiB
iot_agent_deb_arm64 39.872 MiB
iot_agent_deb_armhf 40.442 MiB
iot_agent_rpm_amd64 42.751 MiB
iot_agent_suse_amd64 42.751 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 neutral 182.868 MiB → 184.810
agent_deb_amd64_fips -14.06 KiB (0.01% reduction) 174.311 → 174.297 → 177.560
agent_heroku_amd64 neutral 87.290 MiB → 88.450
agent_msi -4.0 KiB (0.00% reduction) 142.453 → 142.449 → 143.300
agent_rpm_amd64 neutral 185.752 MiB → 188.160
agent_rpm_amd64_fips -16.8 KiB (0.01% reduction) 176.733 → 176.717 → 178.900
agent_rpm_arm64 +33.77 KiB (0.02% increase) 168.374 → 168.407 → 169.930
agent_rpm_arm64_fips +5.21 KiB (0.00% increase) 160.771 → 160.776 → 163.120
agent_suse_amd64 neutral 185.752 MiB → 188.160
agent_suse_amd64_fips -16.8 KiB (0.01% reduction) 176.733 → 176.717 → 178.900
agent_suse_arm64 +33.77 KiB (0.02% increase) 168.374 → 168.407 → 169.930
agent_suse_arm64_fips +5.21 KiB (0.00% increase) 160.771 → 160.776 → 163.120
docker_agent_amd64 neutral 275.087 MiB → 277.400
docker_agent_arm64 +21.07 KiB (0.01% increase) 262.659 → 262.680 → 266.040
docker_agent_jmx_amd64 -2.77 KiB (0.00% reduction) 343.720 → 343.718 → 346.020
docker_agent_jmx_arm64 +26.35 KiB (0.01% increase) 327.276 → 327.302 → 330.660
docker_cluster_agent_amd64 neutral 63.874 MiB → 64.510
docker_cluster_agent_arm64 neutral 60.135 MiB → 61.170
docker_cws_instrumentation_amd64 neutral 2.994 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.726 MiB → 3.090
docker_dogstatsd_amd64 neutral 14.863 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.202 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.832 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.719 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.843 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.843 MiB → 8.800
iot_agent_deb_amd64 neutral 11.212 MiB → 12.040
iot_agent_deb_arm64 neutral 9.584 MiB → 10.450
iot_agent_deb_armhf +2.09 KiB (0.02% increase) 9.779 → 9.781 → 10.620
iot_agent_rpm_amd64 neutral 11.230 MiB → 12.060
iot_agent_suse_amd64 neutral 11.230 MiB → 12.060

@aiuto
Copy link
Contributor Author

aiuto commented Oct 17, 2025

Update on this.
I consulted with security folks and they agree with the concept. They are working on finding the right role to review future changes to cacert.pem within their team.

@aiuto aiuto requested a review from KSerrania December 4, 2025 22:27
@aiuto aiuto marked this pull request as draft December 4, 2025 22:29
@aiuto aiuto changed the title Keep our own copy of cacert.pem [ABLD-169] Keep our own copy of cacert.pem Dec 4, 2025
@aiuto aiuto requested a review from alopezz December 4, 2025 22:57
@aiuto aiuto marked this pull request as ready for review December 4, 2025 22:58
@aiuto aiuto mentioned this pull request Dec 6, 2025
dd-mergequeue bot pushed a commit that referenced this pull request Dec 8, 2025
- Replace omnibus fetch from upstream with that static copy.
- Include text in the BUILD file about how we check for new upstream versions.
- Add explanation of why we have this.
- use cwd to make it a little cleaner
- update cert to 2025-09-09

 It doesn't matter if it is ugly or not. We are going to delete it this quarter anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix/security changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants