Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to sarknet.js v6.11.0 #296

Merged
merged 21 commits into from
Jul 30, 2024
Merged

feat: upgrade to sarknet.js v6.11.0 #296

merged 21 commits into from
Jul 30, 2024

Conversation

khanti42
Copy link
Collaborator

Closes issue #277

@khanti42 khanti42 requested a review from a team as a code owner July 24, 2024 10:17
stanleyyconsensys
stanleyyconsensys requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the http-server in other PR?
And what is the reason to have the debug UI? it is quite outdate
and please also update the starknet.js in wallet ui,get-starknet too

stanleyyconsensys
stanleyyconsensys requested changes Jul 26, 2024
View reviewed changes
packages/starknet-snap/src/utils/keyPair.ts Outdated Show resolved Hide resolved
packages/wallet-ui/package.json Outdated Show resolved Hide resolved
stanleyyconsensys
stanleyyconsensys requested changes Jul 29, 2024
View reviewed changes
packages/wallet-ui/craco.config.js Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@stanleyyconsensys
Copy link
Collaborator

stanleyyconsensys commented Jul 30, 2024 •
edited
Loading

LGTM, Can we pin the starknet version in this PR?

@stanleyyconsensys stanleyyconsensys mentioned this pull request Jul 30, 2024
Merged
2 tasks
stanleyyconsensys
stanleyyconsensys previously approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khanti42 khanti42 merged commit e298244 into main Jul 30, 2024
13 checks passed
@khanti42 khanti42 deleted the feat/sf-660 branch July 30, 2024 10:13
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
@Montoya Montoya mentioned this pull request Oct 1, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys