-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support txv3 in estimateFee (UI) #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
June 27, 2024 05:59
3 tasks
stanleyyconsensys
requested changes
Aug 15, 2024
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
stanleyyconsensys
requested changes
Aug 16, 2024
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
stanleyyconsensys
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the UI to support fee estimation for both transaction versions V2 (pay fee in ETH) and V3 (pay fee in STRK). The changes introduce new components and logic to handle the selected fee token, allowing users to choose between different tokens for fee estimation.
see here for details.
Enregistrement.de.l.ecran.2024-08-14.a.14.11.38.mov
Summary of Changes:
SendModal.view.tsx
:DropDown
component to select the fee token (ETH
orSTRK
).feeToken
.SendSummaryModal.view.tsx
:ETH
orSTRK
) in the fee estimation.useStarkNetSnap.ts
:transactionVersion
as an optional parameter.Impact:
UI Changes:
Users can now select between
ETH
andSTRK
as the fee token. The UI updates ensure that the fee estimation and total amount calculations reflect the selected fee token.Fee Estimation:
Fee estimation now considers the transaction version and selected fee token, improving flexibility.
Display Adjustments:
Updated components to display amounts and fees in the context of the selected fee token.
These updates prepare the UI for enhanced fee estimation capabilities, accommodating future changes and different transaction versions.
Requirement:
Requires this PR to be merged first: