Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing translations #983

Merged
merged 7 commits into from
Oct 28, 2024
Merged

fix: missing translations #983

merged 7 commits into from
Oct 28, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 24, 2024 •
edited
Loading

Summary

Added missing strings.

New pot file: feedzy-rss-feeds.pot.zip

Will affect visual aspect of the product

NO

Check before Pull Request is ready:

Closes #978

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Oct 25, 2024 that may be closed by this pull request
Prepare the plugin for localization #978
Open
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title fix: missing js translations fix: missing translations Oct 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 25, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 25, 2024 13:20
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 25, 2024 •
edited
Loading

Plugin build for 4843865 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 25, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 28, 2024
HardeepAsrani
HardeepAsrani approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@HardeepAsrani HardeepAsrani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a couple of NITs.

@Soare-Robert-Daniel
Copy link
Contributor Author

As discussed, the brands will be separate translate strings so we can get reusability on general strings like %s Support

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit e07d0ab into development Oct 28, 2024
8 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/translation branch October 28, 2024 10:34
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
3 participants
@Soare-Robert-Daniel @pirate-bot @HardeepAsrani