Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the plugin for localization #978

Open
stefan-cotitosu opened this issue Sep 11, 2024 · 2 comments · Fixed by #980, #983 or #997
Open

Prepare the plugin for localization #978

stefan-cotitosu opened this issue Sep 11, 2024 · 2 comments · Fixed by #980, #983 or #997
Assignees
Labels
new feature Request for a new feature or functionality to be added to the project.

Comments

@stefan-cotitosu
Copy link

What problem does this address?

We decided to translate Feedzy to German and to achieve this, the following changes need to be applied to the plugin.

What is your proposed solution?

Localize all the strings

  • Review all the strings within the PHP and JS files of the plugin to make sure they are fully localized and not hardcoded
  • Implement the PHPCS sniff to check for translator comments in the code. Rule to be added: WordPress.WP.I18n.MissingTranslatorsComment

Translate the Formbricks Survey

Reference: Codeinwp/neve@cb3ec00

Will this feature require documentation? (Optional)

No.

@stefan-cotitosu stefan-cotitosu added the new feature Request for a new feature or functionality to be added to the project. label Sep 11, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Sep 27, 2024 that will close this issue
6 tasks
@stefan-cotitosu
Copy link
Author

stefan-cotitosu commented Oct 24, 2024

@Soare-Robert-Daniel, I have some questions here.

  • 1. Should we translate such strings? I tried to see where the function is called, and found this occurrence, where the parameter passed to the function is the string 'Error 1'. Should we translate this string, or this is not visible to the users in the dashboard? 🤔

  • 2.The text on the Feedzy -> Support page, Documentation tab should be also translated considering how we did on Neve.

<p>Learn how to convert feed items into Posts, Pages, or any custom post type.</p>

Image


  • 3. Feedzy -> Support -> Help us Improve!

The heading, text and button on this page aren't translated.

https://github.com/Codeinwp/feedzy-rss-feeds/blob/master/includes/layouts/feedzy-improve.php

Image


  • 4. Feedzy -> Support -> Free vs Pro

The title and table content on this page are not translated.

https://github.com/Codeinwp/feedzy-rss-feeds/blob/master/includes/layouts/feedzy-pro.php

Image


  • 5. Feedzy -> Support -> Getting Started

This page should be translated as well.

<p>Collect the Best Content, Automatically Add It to Your WordPress Site. Grow your site with features like: </p>

Image

@stefan-cotitosu
Copy link
Author

stefan-cotitosu commented Oct 24, 2024

  • 6. Editor.hs strings

meta_values['author'] = __( 'by' ) + ' ' + author;

The strings: by, on, at, in


  • 7.Inspector.js

let refreshFeed = applyFilters('feedzy_widget_refresh_feed', [{ label: __('1 Hour'), value: '1_hours', }, { label: __('2 Hours'), value: '3_hours', }, { label: __('12 Hours'), value: '12_hours', }, { label: __('1 Day'), value: '1_days', }, { label: __('3 Days'), value: '3_days', }, { label: __('15 Days'), value: '15_days', }]);

This labels label: __('1 Hour') should be label: __('1 Hour','feedzy-rss-feeds'), right?

Same situation on:

http_help += __('Please verify that the images exist on HTTPS.');

title={__('Feed Source')}

label={__('Feed Source')}

label={__('Message to show when feed is empty')}

label={__('Number of Items')}

label={__('Sorting Order')}

From

label: __('Default'),

To
label: __('Title Ascending'),

If the problem is valid, please review the whole file as there are many occurences.


@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Oct 25, 2024 that will close this issue
6 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Nov 18, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
2 participants