-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: feed image when using chained actions #946
Merged
Soare-Robert-Daniel
merged 8 commits into
development
from
fix/feed-image-on-chained-actions
Jun 6, 2024
Merged
fix: feed image when using chained actions #946
Soare-Robert-Daniel
merged 8 commits into
development
from
fix/feed-image-on-chained-actions
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirate-bot
added
pr-checklist-incomplete
The Pull Request checklist is incomplete. (automatic label)
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
and removed
pr-checklist-incomplete
The Pull Request checklist is incomplete. (automatic label)
labels
Jun 5, 2024
preda-bogdan
suggested changes
Jun 5, 2024
preda-bogdan
approved these changes
Jun 6, 2024
Merged
🎉 This PR is included in version 4.4.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Indicate that an issue has been resolved and released in a particular version of the product.
label
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-checklist-complete
The Pull Request checklist is complete. (automatic label)
released
Indicate that an issue has been resolved and released in a particular version of the product.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #944 we allowed the custom tags to work with featured images. That condition established a default image for the chained action tags.
I fixed and re-write the condition to make its purpose more clear. Also corrected the serialization for image chained actions.
Note
The users affected by this issue were those using empty chained actions for the featured image.
Will affect visual aspect of the product
NO
Screenshots
Test instructions
Insert Tag
the tagItem Image
Check before Pull Request is ready:
Closes #945