Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feed image when using chained actions #946

Merged
merged 8 commits into from
Jun 6, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Jun 4, 2024

Summary

In #944 we allowed the custom tags to work with featured images. That condition established a default image for the chained action tags.

I fixed and re-write the condition to make its purpose more clear. Also corrected the serialization for image chained actions.

Note

The users affected by this issue were those using empty chained actions for the featured image.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Create a new feed and add via Insert Tag the tag Item Image
  • Also install the Pro version and check the image generation with OpenAI via chained actions.

Check before Pull Request is ready:

Closes #945

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Jun 5, 2024 that may be closed by this pull request
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Jun 5, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review June 5, 2024 14:11
@pirate-bot pirate-bot added pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Jun 5, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Jun 5, 2024

Plugin build for 982c5ab is ready 🛎️!

tests/e2e/specs/import.spec.js Outdated Show resolved Hide resolved
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 19a96af into development Jun 6, 2024
8 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/feed-image-on-chained-actions branch June 6, 2024 13:53
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this pull request Jun 6, 2024
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images no longer imported after the release
3 participants