forked from mitodl/mitx-grading-library
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Py23 unicode #2
Open
ChristopherChudzicki
wants to merge
19
commits into
py23
Choose a base branch
from
py23-unicode
base: py23
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Py23 unicode #2
Commits on Jun 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c92ca24 - Browse repository at this point
Copy the full SHA c92ca24View commit details -
use unicode_literals in baseclasses.py and fix failing tests
This caused some issues with printing nested objects that contain unicode, for example printing dictions now yields something like {u'ok': True, u'msg': u''}. Summary of test changes: - Changed some doctests to test for dict equality instead of printing the dicts - there will be more of these... - Changed some pytest `with raises(Error, match='')` to use a regexp - there will be more of these... - Changed debug log test to include a .format(u=UNICODE_PREFIX) bit that conditionally adds a u-prefix in Python 2. This was simpler than changing the match to a regexp and escaping a whole bunch o stuff.
Configuration menu - View commit details
-
Copy full SHA for 92838b6 - Browse repository at this point
Copy the full SHA 92838b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 189ea26 - Browse repository at this point
Copy the full SHA 189ea26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c43c6 - Browse repository at this point
Copy the full SHA 66c43c6View commit details -
validate/coerce that student_input is unicode or [unicode]
This also unifies very preliminary error checking on student_input
Configuration menu - View commit details
-
Copy full SHA for 30e082c - Browse repository at this point
Copy the full SHA 30e082cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa0b4ec - Browse repository at this point
Copy the full SHA aa0b4ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc478ab - Browse repository at this point
Copy the full SHA cc478abView commit details -
Configuration menu - View commit details
-
Copy full SHA for d41cc46 - Browse repository at this point
Copy the full SHA d41cc46View commit details -
replace (str) with (text_string)
Atom's python-tools find-usage command seems not to miss instances of str wrapped in parens this way...
Configuration menu - View commit details
-
Copy full SHA for 5d29d9b - Browse repository at this point
Copy the full SHA 5d29d9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b35fc3 - Browse repository at this point
Copy the full SHA 5b35fc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b25d2 - Browse repository at this point
Copy the full SHA 44b25d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec46708 - Browse repository at this point
Copy the full SHA ec46708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9f0c3 - Browse repository at this point
Copy the full SHA 5d9f0c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dff1a38 - Browse repository at this point
Copy the full SHA dff1a38View commit details
Commits on Jun 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e43a363 - Browse repository at this point
Copy the full SHA e43a363View commit details -
Configuration menu - View commit details
-
Copy full SHA for f334255 - Browse repository at this point
Copy the full SHA f334255View commit details -
stop checking that student_input is a list in ListGrader.check
This is handled by ListGrader.ensure_text_inputs now, and tested by `tests/test_listgrader.py` function `test_errors`
Configuration menu - View commit details
-
Copy full SHA for d698263 - Browse repository at this point
Copy the full SHA d698263View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c89901 - Browse repository at this point
Copy the full SHA 2c89901View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc375f - Browse repository at this point
Copy the full SHA adc375fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.