Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py23 unicode #2

Open
wants to merge 19 commits into
base: py23
Choose a base branch
from
Open

Py23 unicode #2

wants to merge 19 commits into from

Commits on Jun 29, 2019

  1. Configuration menu
    Copy the full SHA
    c92ca24 View commit details
    Browse the repository at this point in the history
  2. use unicode_literals in baseclasses.py and fix failing tests

    This caused some issues with printing nested objects that contain unicode, for example printing dictions now yields something like {u'ok': True, u'msg': u''}.
    
    Summary of test changes:
        - Changed some doctests to test for dict equality instead of printing the dicts
            - there will be more of these...
        - Changed some pytest `with raises(Error, match='')` to use a regexp
            - there will be more of these...
        - Changed debug log test to include a .format(u=UNICODE_PREFIX) bit that conditionally adds a u-prefix in Python 2. This was simpler than changing the match to a regexp and escaping a whole bunch o stuff.
    ChristopherChudzicki committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    92838b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    189ea26 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66c43c6 View commit details
    Browse the repository at this point in the history
  5. validate/coerce that student_input is unicode or [unicode]

    This also unifies very preliminary error checking on student_input
    ChristopherChudzicki committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    30e082c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa0b4ec View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cc478ab View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d41cc46 View commit details
    Browse the repository at this point in the history
  9. replace (str) with (text_string)

    Atom's python-tools find-usage command seems not to miss instances of str wrapped in parens this way...
    ChristopherChudzicki committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    5d29d9b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5b35fc3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    44b25d2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ec46708 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    5d9f0c3 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    dff1a38 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2019

  1. Configuration menu
    Copy the full SHA
    e43a363 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f334255 View commit details
    Browse the repository at this point in the history
  3. stop checking that student_input is a list in ListGrader.check

    This is handled by ListGrader.ensure_text_inputs now, and tested by `tests/test_listgrader.py` function `test_errors`
    ChristopherChudzicki committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    d698263 View commit details
    Browse the repository at this point in the history
  4. refactor ensure_text_inputs jolyon's way

    it's better =)
    ChristopherChudzicki committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    2c89901 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    adc375f View commit details
    Browse the repository at this point in the history