Py23 unicode #2
Open
Py23 unicode #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
py23-unicode
branch
3 times, most recently
from
f0d1d68
to
2a1db57
Compare
This caused some issues with printing nested objects that contain unicode, for example printing dictions now yields something like {u'ok': True, u'msg': u''}.
Summary of test changes:
- Changed some doctests to test for dict equality instead of printing the dicts
- there will be more of these...
- Changed some pytest `with raises(Error, match='')` to use a regexp
- there will be more of these...
- Changed debug log test to include a .format(u=UNICODE_PREFIX) bit that conditionally adds a u-prefix in Python 2. This was simpler than changing the match to a regexp and escaping a whole bunch o stuff.
This also unifies very preliminary error checking on student_input
Atom's python-tools find-usage command seems not to miss instances of str wrapped in parens this way...
ChristopherChudzicki
force-pushed
the
py23-unicode
branch
from
2a1db57
to
dff1a38
Compare
This is handled by ListGrader.ensure_text_inputs now, and tested by `tests/test_listgrader.py` function `test_errors`
it's better =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.