Timestamp rework

[Hanmac]

Draft for now, i need to update more Effects, so that the WrappedAbility Check can be removed

The Main reason for this MR, Split Timestamp into:

• GameTimestamp that is used by the Rules when an Card becomes an new Object
• LayerTimestamp that is used when the Rules talk about a Card getting a new timestamp, only used for Static Layer Effects

Also

• For Player, add a new check "isInGame" which means the Player has neither lost, nor won (in case of Limited Influence)
• Also More Effects should check for GameTimestamp in Effect so it is checked for Triggered objects
• canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

[tool4ever]

Had the AI play around 50 games on this branch, seems stable so far

If we get the old issues back I think there should be some with timestamp stuff that might get solved

Let me know if I should test for anything else

[Hanmac]

canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

I need rules check if that is true or not.
It may or may not depends on the lines of code if they are on the same line in the oracle.

[Hanmac]

probably need to check for cards that got released after i started working on this for their Triggered values

[tool4ever]

That must have been painful to rebase 😓

Still seems stable

[github-actions]

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

[tool4ever]

Big rebase, hopefully for the last time
I will try and finish this work somehow, I'm tired of timestampCheck

[tool4ever]

Imo it's big enough and should contain at least the most common effects
I'll test drive it one more time and then probably merge to see if we missed something?

[Hanmac]

@tool4ever one of my goals is to remove the "LKICopy" part again, once all the Effects have been updated to check their game states (and if allowed, fall back to LKI)

[tool4ever]

Yea that's the dream
but it can only work if all triggers also provide the right card object, but some are still guilty like here #2193

[Hanmac]

@tool4ever yeah, after this MR we should look at the Discard Trigger and Replacements