Card: differ between Game and Layer Timestamp

[Hanmac]

Smaller PR than #117

@tool4ever can you debug why exactly Kalitas is failing? and why only one of them?

[tool4ever]

Hmn, I think this might come down to a logic error with the new changeZoneLKI structure
If we want to retrieve the previous LKI for Object X, then we need to use the game timestamp it had in its old zone
or in most cases nothing will be found...

[tool4ever]

So there might be two use cases for changeZoneLKI:

• A - we have the new object and want to know its previous LKI
• B - we reference the old object but want its "final" LKI (mostly because of undone statics)

I think A might be rarer?:

1. Used by ReplacementHandler

B:
2. CardProperty: this gets used only partially with focus on controller and zone checks, I remember it fixed some things
3. DamageDeal effects: I think this fixes something like Lifelink by static missing e.g. if a creature dies before it's ability resolves
4. TriggerChangesZone DamageReceivedCondition$: I'll check that one, looks more like a incomplete LKI problem?

5. some other less common parts

in your old branch you refactored 1. to avoid the usage, should still be safe
if we don't need A without it then that could be the complete fix for the test

[Hanmac]

"Used by ReplacementHandler" I need to look at this part

It probably can be changed to use LastStateBattlefield instead

[Hanmac]

@tool4ever so Replacement Handler is updated

[tool4ever]

For triggers we have 2 "problem cases":

• TriggerDestroyed - this uses old zone card, which means Karmic Justice incorrectly triggers for enchantments animated by Opalescence
• TriggerSacrificed - this triggers with LKI, which means cards like It That Betrays need to use Defined$ TriggeredCard to work (which can be broken if you exile and then return it to Graveyard)

So they either

• need both in runParams like TriggerChangesZone
• some AbilityUtils logic that falls back to changeZoneLKI

But that's something that can be decided later