Limit file upload size option #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 21, 2018 19:03
* feature/2814: #2814 schedule deletes in cf2 fiel fields and cleanup that handler a bit #2814 schedule deletes #2814 handle deleting directory if empty Only try to delete file, if it exists #2814 Test to prove that the delete file job will make an uncaught exception in some cases #2814 Make new job for deleting tests work #2814 New job for deleting files #2814 - failing tests Make new utility methods needed for #2814 and #2794 work Failing tests for utility methods needed for #2814 and #2794 #2814 rm dead code and add inline docs to existing delete job
Shelob9
changed the title
|
When a Max upload size is set the error "SyntaxError: "JSON.parse: unexpected character at line 1 column 1 of the JSON data" prevents the submission. It is an error that will be fixed by the index.js refactor, this PR is blocked by issue #2818 |
|
@New0 That sounds like a PHP error during submission. Please retest with PHP debug logging on and report what the error is or what the lack of error is. Please check for PHP errors when testing. |
This was referenced Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1399
I merged
feature/2814(PR #2819). That PR should get merged first probably.This adds a UI option for max upload size for HTML5 file fields and adv file fields 2.0.
This checks server-side if adv file fields 2.0 size is too large and rejects.
We might wish to, in order of how much I care: