Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to limit file size for adv file 2.0 and standard file fields #1399

Closed
AkremBelkahla opened this issue Mar 14, 2017 · 3 comments
Closed

Option to limit file size for adv file 2.0 and standard file fields #1399

AkremBelkahla opened this issue Mar 14, 2017 · 3 comments
Assignees
@Shelob9
Labels
enhancement New feature Has PR Bug/Feature with a PR created for it.
Milestone
1.8.0

Comments

@AkremBelkahla
Copy link

AkremBelkahla commented Mar 14, 2017 •
edited
Loading

The file size control is working by file instead of the total files size.

2017-03-14 11 31 06

In this example, limit of file size uploading is 2Mo.
@Shelob9
Copy link
Collaborator

Shelob9 commented Mar 14, 2017

Correct, that is how this works. I'm going to retitled this as a feature request. As it would be a cool feature if it could do that.

@Shelob9 Shelob9 changed the title File size control Option to limit advanced file fields total (not each file) upload size Mar 14, 2017
@Shelob9 Shelob9 added this to the 1.6.0 milestone Mar 14, 2017
@Shelob9 Shelob9 added the enhancement New feature label Mar 14, 2017
@EnekoPrins EnekoPrins mentioned this issue Aug 23, 2017
Open
@Shelob9 Shelob9 modified the milestones: 1.7.0, 1.7.1 May 9, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.1, 1.7.2 Jun 4, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.2, 1.7.3 Jun 25, 2018
@Shelob9 Shelob9 modified the milestones: 1.7.3, 1.8.0 Jul 5, 2018
@Shelob9 Shelob9 self-assigned this Nov 20, 2018
@Shelob9 Shelob9 mentioned this issue Nov 20, 2018
Merged
@Shelob9 Shelob9 changed the title Option to limit advanced file fields total (not each file) upload size Option to limit file size for adv file 2.0 and standard file fields Nov 21, 2018
@Shelob9
Copy link
Collaborator

Shelob9 commented Nov 21, 2018

Changing name to reflect that is will be implimented in standard file file fields and advanced file fields 2.0, not advanced file fields 1.0.

@Shelob9 Shelob9 mentioned this issue Nov 22, 2018
Merged
Shelob9 referenced this issue Nov 22, 2018
UI option for limiting upload size in new file fields and the html5 f…
ef5f3e6 
…ile field
Shelob9 pushed a commit that referenced this issue Nov 22, 2018
failing test for methods needed in #1399
d878e9d
Shelob9 pushed a commit that referenced this issue Nov 22, 2018
make utility methods for #1399 work
7e8e20e
Shelob9 pushed a commit that referenced this issue Nov 22, 2018
impliment the max file upload check for adv file fields 2.0 #1399
44c89e0
@Shelob9 Shelob9 added the Has PR Bug/Feature with a PR created for it. label Nov 22, 2018
New0 added a commit that referenced this issue Jan 22, 2019
@New0
Remove white space #1399
f19f1ae
New0 added a commit that referenced this issue Jan 24, 2019
@New0
Return correct boolean from is_file_too_large() function #1399
a14b3c3
Shelob9 pushed a commit that referenced this issue Jan 24, 2019
Merge pull request #2823 from CalderaWP/feature/1399
6e707fd 
 Limit file upload size option Fixes #1399
@Shelob9
Copy link
Collaborator

Shelob9 commented Jan 24, 2019

Close via 6e707fd #2823

@Shelob9 Shelob9 closed this as completed Jan 24, 2019
@Shelob9 Shelob9 mentioned this issue Jan 24, 2019
Closed
@Shelob9 Shelob9 mentioned this issue Feb 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shelob9 Shelob9

Labels
enhancement New feature Has PR Bug/Feature with a PR created for it.
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@Shelob9 @AkremBelkahla