Integrate new file fields #2775

Shelob9 · 2018-10-18T21:01:00Z

* feature/2771: markdown fix in testing docs #2771 migrate in e2e tests #2771 Setup test imports for e2e tests #2771 setup unit tests seperate from WordPress 'unit' tests #2701 cypress tests #2771 cache dirs on travis #2771 make phpunit integration tests run locally in container #2711 docker install scripts #2771 added to bin #2771 delete old docker env # Conflicts: # package-lock.json

Shelob9 · 2018-10-18T21:02:18Z

NOTES to resolve before merge:

I hardcoded add_filter( 'caldera_forms_render_assets_minify', '__return_false' ); in main plugin file. Dev environment needs a mu-plugins dir for this.
I removed init of old trackign system, which we should do.
I removed freemius, which we should not do

* feature/2771: fix bad package lock do not run cypress tests with Jest #2771 #2771 run isolated unit tests in Travis Revert "record cypress test run in travis #2771" record cypress test run in travis #2771 Prepare for cypress in CI #2771 Minor code clean up for #2768 Restore new form ID for cloned new forms # Conflicts: # package-lock.json

…ests for that

Shelob9 · 2018-10-23T14:40:58Z

To finish this:

@New0 Make button look like the old button https://github.com/CalderaWP/Caldera-Forms/blob/9ecc5d67b9d5426516ce2b1f2dd399cd0b8f5f5e/clients/tests/unit/render/Fields/FileInput.test.js
@Shelob9 Make cf2 fields repeat
@Shelob9 Finish making it submit and write tests for that.

# Conflicts: # assets/build/css/caldera-forms-front.min.css # assets/css/caldera-forms-front.css # assets/js/caldera-forms-front.js # tests/bootstrap-unit.php

Shelob9 · 2018-10-25T14:36:01Z

@New0 For button style:

It should look the same (the drag or click to upload element) as an existing file field. This should be done by applying existing rules using same classes. IE If I had an advanced file field and targetted it with custom CSS in my theme, those rules should have same effect on new file field. Be careful that cf-uploader-trigger class is what advanced file fields bind to, and using that is a bad idea.
Drag over should still work.

Shelob9 · 2018-10-25T14:57:21Z

TODOS

Front-end @New0

Style
Image preview (this is a feature I will let go off)
Support multiple
Submit

Server-side @Shelob9

Integrate with existing abstractions for upload handler, file path.
Tests for above
Test form submission with cf_file fields
e2e Tests @Shelob9
Integration tests for wp_mail (attached properly)
Integration tests for CF Pro emails (attached properly, there is an API endpoint for this)

- console errors need to be removed - other tests needed to complete this series - review pertinence of all tests and remove non useful tests

This test is made with correct props with enzyme at L187 in clients\tests\unit\render\Fields\Mocks\MockFileRenderer.test.js This should also make Trvis ci tests pass ( #2802 )

* #2801 add a job manager * #2801 run queue manager * schedule delete with job manager #2801 * Remove var_dump #2801 * mild cleanup for starting the runner #2801 * add queue run endpoint #2801 * rest api route for running queue now checked with CF PRo api keys #2801 * #2801 more tests for the run queue endpoint and fixed its response * Resolve Conflicts #2802 * Resolve conflicts #2802 * Resolve conflicts #2802

Shelob9 · 2018-11-16T02:55:24Z

@New0 When we talk next,

discuss naming, labeling, icon and if we move existing advanced file fields to deprecated or what not.
There is no * for required fields.
The preview in Gutenberg block does not render this field.
Next field types to cf2afy - I argue checkboxes, radios since they are the ones with bad markup and more fragile code for reading/updating state via jQuery.val or whatever in state/conditionals.

…ed and they have no value, you can submit the form

- #2775 (comment)

…to false by default #2766

… required with a * and the right markup

…cator #2766

…rver-side

…ture/2766 # Conflicts: # classes/forms.php # tests/test-entry-fields-collection.php # tests/test-forms-api.php # tests/test-save.php

- Make all Files Field component texts translatable - When multiple isn't allowed and a file is set, let the button displayed as disabled instead of hiding it and adding text.

Shelob9 · 2018-11-20T20:51:20Z

@New0 I am going to merge this to develop and tag an alpha today. This works. #2814 and #1399 can be separate PRs we can get into alpha 2.

Josh Pollock added 2 commits October 18, 2018 15:50

#2766 add client for front-end render

8f4043c

Shelob9 added the PR (Patch) Is a pull request label Oct 18, 2018

Shelob9 added this to the 1.8.0 milestone Oct 18, 2018

Shelob9 self-assigned this Oct 18, 2018

Josh Pollock added 11 commits October 18, 2018 17:32

basic POC for rendering via React, state managed with CF State #2766

d0a6192

#2766 get cf2 field rendering working correctly for the most part

b96204b

impliment disbale conditionals for cf2 fields #2766

26b7a9c

#2766 move new field rendering to a field group component and write t…

51184d1

…ests for that

#2766 set required and disabled props more intelligently

f449034

get validation slightly working for cf2 fields #2766

ba2d295

add cf2 field values to submit request #2766

769cfe2

#2766 update state with default for cf2 fields correctly

b727677

move input to its own component #2771

a52b1fc

#2776 additional work on file field cf2 rendering and conditionals

9ecc5d6

Josh Pollock added 5 commits October 23, 2018 10:44

#2766 more work on cf2 file fields

800f711

#2771 php5 compatible include

ec664fc

Merge branch 'develop' into feature/2766

9b020f5

# Conflicts: # assets/build/css/caldera-forms-front.min.css # assets/css/caldera-forms-front.css # assets/js/caldera-forms-front.js # tests/bootstrap-unit.php

Merge branch 'develop' into feature/2766

93b3f13

endpoint for uploading files from file fields against #2766

4ff1985

New0 mentioned this pull request Oct 25, 2018

[WIP] Setting FileFieldGroup CalderaWP/caldera-components#18

Open

Josh Pollock added 4 commits October 25, 2018 12:57

add one command for all php tests #2766

626b610

seperate file upload logic from rest api handler #2766

f371307

seperate file upload logic from rest api handler #2766

3aba811

test new upload handlers #2766

8fbf3f8

New0 and others added 5 commits November 14, 2018 11:09

[WIP] Tests for FileInput.js and progress based on tests #2766

67c1427

- console errors need to be removed - other tests needed to complete this series - review pertinence of all tests and remove non useful tests

Make button text always an option #2766

c850d41

Adapt unit test for default button text #2766

7891502

Remove unnecessary unit test

e497b8e

This test is made with correct props with enzyme at L187 in clients\tests\unit\render\Fields\Mocks\MockFileRenderer.test.js This should also make Trvis ci tests pass ( #2802 )

Josh Pollock and others added 20 commits November 15, 2018 22:04

#2766 more cypress tests to ensure that if file fields are not requir…

be6d6ea

…ed and they have no value, you can submit the form

Code change based on @Shelob9 comment ( link in description )

0b0c94e

- #2775 (comment)

Resolve conflicts #2766

4d04990

fix extra comma in conditionals.js causing minification error #2766

a8fa334

cleanup in the test files before adding new tests #2766

10bc215

cleanup in the test files before adding new tests #2766

8800eed

test to prove that new file field validation does NOT set isRequired …

d76d57e

…to false by default #2766

#2766 tests to prove that the file field does not indicate that it is…

2b48a85

… required with a * and the right markup

clean up and inline docs in the CalderaFormsFieldGroup component #2766

71cc344

tests to prove that the field group component is NOT showing a * indi…

9e33d6d

…cator #2766

#2766 tests to prove that the isRequired prop is not set correctly se…

7ff3749

…rver-side

#2766 cf2 fiel field required indicator

d1f48a5

set icon for file fields #2766

6baa6fd

#2766 update test data to use field.isRequired

7776bbc

correct the isRequired check #2766

0b8e88c

Merge branch 'develop' of github.com:CalderaWP/Caldera-Forms into fea…

6859891

…ture/2766 # Conflicts: # classes/forms.php # tests/test-entry-fields-collection.php # tests/test-forms-api.php # tests/test-save.php

#2766 load tables for new job queue correctly

3365fff

#2766 Make Text Translatable and let the button disabled

c6f6877

- Make all Files Field component texts translatable - When multiple isn't allowed and a file is set, let the button displayed as disabled instead of hiding it and adding text.

remove console logs in tests #2766

6505f50

minor cleanups #2766

954c14e

Shelob9 merged commit 954c14e into develop Nov 20, 2018

Shelob9 mentioned this pull request Nov 20, 2018

Integrate Adv File Fields 2.0 in Caldera Forms #2766

Closed

9 tasks

Shelob9 changed the title ~~[WIP] Integrate new file fields~~ Integrate new file fields Nov 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate new file fields #2775

Integrate new file fields #2775

Shelob9 commented Oct 18, 2018

Shelob9 commented Oct 18, 2018

Shelob9 commented Oct 23, 2018

Shelob9 commented Oct 25, 2018

Shelob9 commented Oct 25, 2018

Shelob9 commented Nov 16, 2018 •

edited

Loading

Shelob9 commented Nov 20, 2018 •

edited

Loading

Integrate new file fields #2775

Integrate new file fields #2775

Conversation

Shelob9 commented Oct 18, 2018

Shelob9 commented Oct 18, 2018

Shelob9 commented Oct 23, 2018

Shelob9 commented Oct 25, 2018

Shelob9 commented Oct 25, 2018

Shelob9 commented Nov 16, 2018 • edited Loading

Shelob9 commented Nov 20, 2018 • edited Loading

Shelob9 commented Nov 16, 2018 •

edited

Loading

Shelob9 commented Nov 20, 2018 •

edited

Loading