Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Adv File Fields 2.0 in Caldera Forms #2766

Closed
7 of 9 tasks
Shelob9 opened this issue Oct 16, 2018 · 1 comment
Closed
7 of 9 tasks

Integrate Adv File Fields 2.0 in Caldera Forms #2766

Shelob9 opened this issue Oct 16, 2018 · 1 comment
Assignees
Labels
enhancement New feature Has PR Bug/Feature with a PR created for it.
Milestone

Comments

@Shelob9
Copy link
Collaborator

Shelob9 commented Oct 16, 2018

Changes to front-end rendering to accommodate React-rendered fields such as this.

@Shelob9 Shelob9 added the enhancement New feature label Oct 16, 2018
@Shelob9 Shelob9 added this to the 1.8.0 milestone Oct 16, 2018
@Shelob9 Shelob9 self-assigned this Oct 16, 2018
Shelob9 pushed a commit that referenced this issue Oct 18, 2018
Shelob9 pushed a commit that referenced this issue Oct 20, 2018
Shelob9 pushed a commit that referenced this issue Oct 23, 2018
Shelob9 pushed a commit that referenced this issue Oct 23, 2018
Shelob9 pushed a commit that referenced this issue Oct 23, 2018
Shelob9 pushed a commit that referenced this issue Oct 25, 2018
Shelob9 pushed a commit that referenced this issue Oct 25, 2018
Shelob9 pushed a commit that referenced this issue Oct 25, 2018
Shelob9 pushed a commit that referenced this issue Oct 26, 2018
New0 added a commit that referenced this issue Nov 14, 2018
New0 added a commit that referenced this issue Nov 19, 2018
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
…ed and they have no value, you can submit the form
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
Shelob9 pushed a commit that referenced this issue Nov 19, 2018
@Shelob9 Shelob9 added the Has PR Bug/Feature with a PR created for it. label Nov 20, 2018
New0 added a commit that referenced this issue Nov 20, 2018
- Make all Files Field component texts translatable
- When multiple isn't allowed and a file is set, let the button displayed as disabled instead of hiding it and adding text.
Shelob9 pushed a commit that referenced this issue Nov 20, 2018
Shelob9 pushed a commit that referenced this issue Nov 20, 2018
Shelob9 pushed a commit that referenced this issue Nov 20, 2018
* feature/2766: (95 commits)
  minor cleanups #2766
  #2766 Make Text Translatable and let the button disabled
  #2766 load tables for new job queue correctly
  correct the isRequired check #2766
  #2766 update test data to use field.isRequired
  set icon for file fields #2766
  #2766 cf2 fiel field required indicator
  #2766 tests to prove that the isRequired prop is not set correctly server-side
  tests to prove that the field group component is NOT showing a * indicator #2766
  clean up and inline docs in the CalderaFormsFieldGroup component #2766
  #2766 tests to prove that the file field does not indicate that it is required with a * and the right markup
  test to prove that new file field validation does NOT set isRequired to false by default #2766
  cleanup in the test files before adding new tests #2766
  cleanup in the test files before adding new tests #2766
  Resolve conflicts #2766
  Code change based on @Shelob9 comment ( link in description )
  #2766 more cypress tests to ensure that if file fields are not required and they have no value, you can submit the form
  Create a proper job manager for deleting transients etc. (#2802)
  Remove unnecessary unit test
  Adapt unit test for default button text #2766
  ...

# Conflicts:
#	caldera-core.php
#	clients/blocks/build/index.min.js
#	clients/blocks/build/index.min.js.map
#	clients/privacy/build/index.min.js
#	clients/privacy/build/index.min.js.map
#	clients/pro/build/index.min.js
#	clients/pro/build/index.min.js.map
#	cypress/tests.json
#	package-lock.json
#	package.json
#	tests/test-forms-api.php
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Nov 20, 2018

Close via 954c14e #2775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature Has PR Bug/Feature with a PR created for it.
Projects
None yet
Development

No branches or pull requests

1 participant