Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CF2 init hooks in caldera-core.php to another file. #2830

Closed
Shelob9 opened this issue Nov 26, 2018 · 2 comments
Closed

Move CF2 init hooks in caldera-core.php to another file. #2830

Shelob9 opened this issue Nov 26, 2018 · 2 comments
Assignees
@Shelob9
Labels
Blocker For Next Release Highest severity bugs. enhancement New feature Has PR Bug/Feature with a PR created for it.
Milestone
1.8.0

Comments

@Shelob9
Copy link
Collaborator

Shelob9 commented Nov 26, 2018

There are a few hooks in caldera-core.php that need moved -- that file must be PHP 5.2 compatible/ it's bad organization.

Related #2824 #2766
@Shelob9 Shelob9 added enhancement New feature Blocker For Next Release Highest severity bugs. labels Nov 26, 2018
@Shelob9 Shelob9 added this to the 1.8.0 milestone Nov 26, 2018
@Shelob9 Shelob9 self-assigned this Nov 26, 2018
Shelob9 pushed a commit that referenced this issue Dec 14, 2018
#2830 test that container was setup
4dcfa69
Shelob9 pushed a commit that referenced this issue Dec 14, 2018
Add test for upgrade of file field type #2830
b922996
Shelob9 pushed a commit that referenced this issue Dec 14, 2018
Move init functions for CF2 to PHP 5.2 sage location #2830
cf52558
@Shelob9 Shelob9 mentioned this issue Dec 14, 2018
Merged
Shelob9 pushed a commit that referenced this issue Dec 14, 2018
Merge branch 'develop' into feature/2830 #2830
e8dae2e 
* develop:
  During form submission, start buffer, then flush it. #2820 and #2448 and #2788
  Set window.cf2 if not an object #2821
  #2814 schedule deletes in cf2 fiel fields and cleanup that handler a bit
  #2814 schedule deletes
  #2814 handle deleting directory if empty
  Only try to delete file, if it exists #2814
  Test to prove that the delete file job will make an uncaught exception in some cases #2814
  Make new job for deleting tests work #2814
  New job for deleting files #2814 - failing tests
  Make new utility methods needed for #2814 and #2794 work
  Failing tests for utility methods needed for #2814  and #2794
  #2814 rm dead code and add inline docs to existing delete job

# Conflicts:
#	cf2/functions.php
@Shelob9 Shelob9 added the Has PR Bug/Feature with a PR created for it. label Dec 14, 2018
@Shelob9
Copy link
Collaborator Author

Shelob9 commented Dec 14, 2018

Should be fixed via #2861

@New0
Copy link
Collaborator

New0 commented Dec 17, 2018

Closed via 86153a1

@New0 New0 closed this as completed Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shelob9 Shelob9

Labels
Blocker For Next Release Highest severity bugs. enhancement New feature Has PR Bug/Feature with a PR created for it.
Projects
None yet
Milestone
1.8.0
Development

No branches or pull requests
2 participants
@Shelob9 @New0