PKGBUILD: Make LTO a hard dependency when building with clang #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In hindsight, there's not much to be gained by compiling clang without LTO. Faster compile times can be achieved but the additional time it takes using LTO hardly matters on modern computers. Forcing this on also makes it simple for the build script we use because the clang-specific features aren't available on GCC (obviously). Also refactored the pkgsuffix conditions to use _is_lto_kernel instead to make it cleaner. Suggested-by: Vasiliy Stelmachenok <[email protected]> Signed-off-by: Eric Naim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight, there's not much to be gained by compiling clang without LTO. Faster compile times can be achieved but the additional time it takes using LTO hardly matters on modern computers.
Forcing this on also makes it simple for the build script we use because the clang-specific features aren't available on GCC (obviously).
Also refactored the pkgsuffix conditions to use _is_lto_kernel instead.