linux-cachyos{,-rc}: Conditionally add clang-llvm to headers dependencies #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptr1337
approved these changes
Dec 5, 2024
|
Probably doesn't work properly: Even building with GCC requires CLANG |
as mentioned - that is just a bug of the .srcinfo generation |
That's just .SRCINFO generation. Actual package is correct. |
ptr1337
approved these changes
Dec 6, 2024
In hindsight, there's not much to be gained by compiling clang without LTO. Faster compile times can be achieved but the additional time it takes using LTO hardly matters on modern computers. Forcing this on also makes it simple for the build script we use because the clang-specific features aren't available on GCC (obviously). Also refactored the pkgsuffix conditions to use _is_lto_kernel instead to make it cleaner. Suggested-by: Vasiliy Stelmachenok <[email protected]> Signed-off-by: Eric Naim <[email protected]>
Since we are compiling the default kernel with clang rather than GCC, we need to pull clang as a dependency to ensure functionality with building out-of-tree kernel modules. For CachyOS users, this is already seamless because our dkms package is dependent on clang, but AUR users and non-CachyOS users can suffer from this. Note that this generates a bogus .SRCINFO when !_is_clang_kernel() but that doesn't matter for 100% of usecases because it's default True (unless some third party repository defaults to GCC in which case they should fix it on their own). Closes #346 Signed-off-by: Eric Naim <[email protected]>
Signed-off-by: Eric Naim <[email protected]>
1Naim
force-pushed
the
fix/kernel-clang-deps
branch
from
3d51457 to
d72afd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are compiling the default kernel with clang rather than GCC, we need to pull clang as a dependency
to ensure functionality with building out-of-tree kernel modules. For CachyOS users, this is already seamless
because our dkms package is dependent on clang, but AUR users and non-CachyOS users can suffer from this.
Note that this generates a bogus .SRCINFO when !_is_clang_kernel() but that doesn't matter for 100% of usecases
because it's default True (unless some third party repository defaults to GCC in which case they should fix it
on their own).
Depends on #354