Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Syphilis AOE copy and order #8130

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update Syphilis AOE copy and order #8130

merged 1 commit into from
Sep 23, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Sep 20, 2024 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • This ticket became mostly a copy change and style update ticket since I think Bob(?) had already done all of the work to add syphilis AOE to the test card.
  • Change "Is the patient currently experiencing any symptoms?" to "Is the patient currently experiencing or showing signs of symptoms?" for all diseases
  • Fix incorrect SNOMED for "Blurred vision"
  • Add "Alopecia" to symptoms
  • Change order of AOE Syphilis questions as requested in the ticket
  • Make style updates to Syphilis form to satisfy the following part of acceptance criteria:

Responsiveness: The Results screen should adapt to different screen sizes and devices, providing a consistent experience across platforms.

Additional Information

  • I thought there would be more work for this ticket... Let me know if I'm missing any context from that ticket 😅

Testing

  • Test locally and test Test Cards
    • see updated symptoms copy for every disease
    • try responsiveness of Syphilis form at different breakpoints
    • see updated symptoms for Syphilis

Screenshots / Demos

Before

  • Desktop
Screenshot 2024-09-20 at 10 24 17
  • iPad
Screenshot 2024-09-20 at 10 25 05 Screenshot 2024-09-20 at 10 25 12

After

  • Desktop
Screenshot 2024-09-20 at 10 26 22
  • iPad
Screenshot 2024-09-20 at 10 26 37 Screenshot 2024-09-20 at 10 26 41

@emyl3 emyl3 force-pushed the elisa/8100-syphilis-aoe-test-card branch from 32b557b to 859d133 Compare September 20, 2024 12:49
@emyl3 emyl3 force-pushed the elisa/8100-syphilis-aoe-test-card branch from 859d133 to 3faaf9a Compare September 20, 2024 12:53
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

emyl3
emyl3 commented Sep 20, 2024
View reviewed changes
frontend/src/patientApp/timeOfTest/constants.ts
@@ -97,8 +97,8 @@ export const syphilisSymptomsMap = {
"56940005": "Palmar (hand)/plantar (foot) rash",
"91554004": "Flat white warts",
"15188001": "Hearing loss",
"46636008": "Blurred vision",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Noticed the SNOMED we had originally for "Blurred vision" was incorrect (before 46636008, after 246636008) see #8100 description as well

@emyl3 emyl3 marked this pull request as ready for review September 20, 2024 16:56
emyl3
emyl3 commented Sep 20, 2024
View reviewed changes
frontend/src/app/testQueue/TestCardForm/diseaseSpecificComponents/SyphilisAoEForm.tsx
@@ -148,8 +148,8 @@ export const SyphilisAoEForm = ({
</div>
</div>
{hasSymptoms === "YES" && (
<div className={"grid-row grid-gap width-full flex-start"}>
<div className={`flex-${CHECKBOX_COLS_TO_DISPLAY - 1}`}>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ this class made other screen sizes have a not great experience

emyl3
emyl3 commented Sep 20, 2024
View reviewed changes
frontend/src/app/testQueue/testCardTestConstants.ts
@@ -83,7 +83,7 @@ const GENDER_SEXUAL_PARTNERS_FEMALE_OVERRIDE = {
};
const BLURRED_VISION_OVERRIDE = {
symptoms:
'{"15188001":false,"26284000":false,"46636008":true,"56940005":false,"68225006":false,"91554004":false,"195469007":false,"266128007":false,"724386005":false}',
'{"15188001":false,"26284000":false,"56317004":false,"56940005":false,"91554004":false,"195469007":false,"246636008":true,"266128007":false,"724386005":false}',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ the change here is Alopecia (SNOMED: 56317004), the snomed for blurred vision is corrected from 46636008 to 246636008 and the order of the others were changed

mpbrown
mpbrown approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM running it locally!

bobbywells52
bobbywells52 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and everything looks good to me. The styling on the tablets looks so much better 🤩 great work on this!

@emyl3 emyl3 added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit a63182a Sep 23, 2024
34 of 36 checks passed
@emyl3 emyl3 deleted the elisa/8100-syphilis-aoe-test-card branch September 23, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Syphilis] Add condition and new AOE questions to Conduct Test - Test Card screen
3 participants
@emyl3 @mpbrown @bobbywells52