Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experience/15823/fix link checker #15919

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

etanb
Copy link
Collaborator

@etanb etanb commented Sep 18, 2024

Our app does not properly handle 200 vs 400 HTTP codes for our pages, so we cannot simply use Axios since it's an HTTP client only. This means we must actually navigate to the page(s) with Playwright to decipher the rendered HTML DOM content to determine if the page is valid or not.

isAbsoluteURL determines if the page is an internal link or an external one by checking if it's an absolute URL or a relative URL.

Fixes: #15823

Copy link

github-actions bot commented Sep 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@etanb etanb marked this pull request as ready for review September 20, 2024 00:22
@etanb etanb added the experience Team label to flag issues owned by the Experience Team label Sep 20, 2024
Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 3 tests with visual changes.
  • ✅ All tests passed.

View via:

Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experience Team label to flag issues owned by the Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E Link Checker Doesn't Properly Check Internal Links
1 participant