Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNFT1-2776 API: Create Extended patient data entry form for Ethnicity #1844

Merged
merged 12 commits into from
Sep 25, 2024
Merged

CNFT1-2776 API: Create Extended patient data entry form for Ethnicity #1844

merged 12 commits into from
Sep 25, 2024

Conversation

stevegsa
Copy link
Collaborator

@stevegsa stevegsa commented Sep 20, 2024 •
edited
Loading

Description

Work in progres...

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@stevegsa stevegsa force-pushed the steveu-api-extended-patient-ethnicity branch from 68fb32e to 0feded5 Compare September 24, 2024 17:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adamloup-enquizit
adamloup-enquizit approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@adamloup-enquizit adamloup-enquizit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

💀 the formatting changes 💀

@stevegsa stevegsa merged commit 63d426c into main Sep 25, 2024
2 checks passed
@adamloup-enquizit adamloup-enquizit deleted the steveu-api-extended-patient-ethnicity branch September 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamloup-enquizit adamloup-enquizit adamloup-enquizit approved these changes

@mpeels mpeels mpeels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevegsa @mpeels @adamloup-enquizit