Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real header elements. Fix No Data in table. Adjust card #1840

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use real header elements. Fix No Data in table. Adjust card #1840

wants to merge 3 commits into from

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 19, 2024 •
edited
Loading

Description

  1. Updates Heading component to use h1-h6 based on level provided
  2. Removes display: inline-block; from .no-data class to fix table display
  3. Updates Card component to optionally accept a level property that specifies the heading level
  4. Update some header styles to prevent cascading of padding

Tickets

🤠

No Data display

image

Prevent header padding cascade (1rem on top, 1.5 on bottom sections)

image

image

Card component using new Heading's default h2

image

@mpeels mpeels marked this pull request as ready for review September 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamloup-enquizit adamloup-enquizit Awaiting requested review from adamloup-enquizit adamloup-enquizit is a code owner

@hclarkEnq hclarkEnq Awaiting requested review from hclarkEnq

@alaapbharadwaj alaapbharadwaj Awaiting requested review from alaapbharadwaj

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpeels