Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnft1 2775 ethnicity section #1837

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Cnft1 2775 ethnicity section #1837

merged 3 commits into from
Sep 20, 2024

Conversation

mpeels
Copy link
Collaborator

@mpeels mpeels commented Sep 19, 2024

Description

  1. Adds the ethnicity section to the extended patient creation.
  2. Fixes the ID on the MultiSelect component. The id prop is being added to a div, changing to use the inputId prop correctly sets the id on the input element. This fixes issues when trying to getByLabelText where an error is thrown causing a test failure.
  3. Fixes typo in PatientEthnicityCodedValue type.

Tickets

Demo

ethnicity

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@mpeels mpeels marked this pull request as ready for review September 19, 2024 17:56
Copy link
Collaborator

@hclarkEnq hclarkEnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mpeels mpeels merged commit 81c75da into main Sep 20, 2024
1 check passed
@mpeels mpeels deleted the CNFT1-2775-ethnicity-section branch September 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants