Rewrite wiki-tui #226
Merged
Rewrite wiki-tui #226
+5,321
−7,685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add wiki-api - add wiki-api-macros - clear wiki-tui
- add app::App - add Component trait - add Root component
- add Logger component - add Action::ToggleShowLogger
refactor: remove virtual workspace refactor: create root package wiki-tui
- add Parser trait - add WikipediaParser - add Renderer trait - add basic TestRenderer
- fix recursive Node::index() - add Descendants with depth to TestRenderer - add debug key event to open test page
Builditluc
added
the
breaking-change
- show span with class 'mw:Transclusion' - hide span with class 'cs1-maint' - hide span with class 'mw-editsection' - hide span with class 'mw:Nowiki'
- add whitespace after bold element - add whitespace after italic element
- account for borders and highlight symbol when calculating available width for the snippet - don't handle scrolling actions when no page is present
- Enter the search bar after startup - Restyle the scrollbar - Make links blue - Implement basic link selection (First, Last, Left, Right) - Add horizontal lines after Main and Sub headings
2 tasks
Builditluc
force-pushed
the
rewrite-wiki-tui
branch
from
8af8440
to
5f3d7af
Compare
- renamed dispatch to update - update and handle_key_events now return ActionResult - add ActionResult, ActionPacket - remove Context, use single actions instead - remove Action::ExitInsert, Action::ExitProcessing - AppComponent will now only dispatch actions to the current Context
- rename ResultsList -> StatefulList - improve StatefulList
|
I tried the rewrited version and it worked much better with Chinese/Japanese than the older version!
|
|
Thank you! I currently don't have a lot of time to work on the project (finals), so it'll take a bit to finish the rewrite. |
The reason is that it was too complicated and we don't really need such a detailed system yet.
Builditluc
force-pushed
the
rewrite-wiki-tui
branch
from
29d982a
to
ad4474f
Compare
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked isssues
This PR tracks the rewrite of wiki-tui's core structure and implementation. The plan is to implement the core features (viewing Wikipedia articles in the terminal), move things over to the main branch, and implement the other features like switching languages there.
You can always check the current state of development here. Feedback, Suggestions and Ideas are greatly appreciated!
Todo / Info board