Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Blockquotes are hidden, rather than unsupported #228

Open
1 of 2 tasks
Kyllingene opened this issue Dec 19, 2023 · 1 comment
Open
1 of 2 tasks

[BUG] Blockquotes are hidden, rather than unsupported #228

Kyllingene opened this issue Dec 19, 2023 · 1 comment
Labels
type: bug This fixes a bug. Increment the minor version

Comments

@Kyllingene
Copy link

Kyllingene commented Dec 19, 2023

General Information
Version: 0.8.2
Installation Method: cargo install wiki-tui
Operating System: Arch Linux
Backend (If changed during install): N/A

Describe the bug
When browsing Wikipedia, one often encounters a blockquote. An example of a page using one is Pindar. However, in wiki-tui, these aren't displayed at all, not even an Unsupported element error; the behavior is that described in #113. Screenshots are below.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any wiki page with a quote (like the one used here)
  2. Scroll to quote
  3. Observe the blank space where the quote should be

Expected behavior
The quote should be displayed, probably as an indented piece of text (like on Wikipedia). These seem to be represented as <blockquote>, so there shouldn't be any difficulty in supporting them.

Screenshots
Wikipedia:
image

wiki-tui:
image

Checklist

  • checked other issues for the same bug
  • read CONTRIBUTING.md
@Kyllingene Kyllingene added the type: bug This fixes a bug. Increment the minor version label Dec 19, 2023
@Builditluc
Copy link
Owner

Hey @Kyllingene,
thank you for you bug report!

I could reproduce the issue. I'm currently rewriting wiki-tui's core structure completely (aswell as the UI) in #226, where the block quotes are being properly displayed (the rewrite is still in early development, so bugs may occur).

The current plan with the rewrite is to get the core features implemented (viewing and searching articles in Wikipedia), move things over to the main branch and continue implementing the other features (language switching, etc.) there.

If you want the quotes to be fixed / released asap, I can work out a patch for 0.8.2 (current version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug This fixes a bug. Increment the minor version
Projects
Status: Todo
Development

No branches or pull requests

2 participants