Fix install-core and persistent-setup dialog in Tails 6 #116
Conversation
…ub.com/BenWestgate/Bails into 107-write-passphrase-down-dialog-funky
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
@epiccurious check out the dialog text changes and if you think they're better approve them and this will auto-merge to master. |
bin/install-core
Outdated
| " | ||
|
|
||
| for ((i = 10; i >= 1; i--)); do | ||
| for ((i = 30; i >= 1; i--)); do |
There was a problem hiding this comment.
Should this be a hard-coded variable like ${sleep_time} for this line and line 274?
There was a problem hiding this comment.
Not if I or the script never plan to change it again.
bin/persistent-setup
Outdated
| @@ -115,8 +122,18 @@ fi | |||
|
|
|||
| # Display memorization tips | |||
| zenity --info --title='Tips for your new passphrase' \ | |||
| --text="You will be prompted periodically to enter your passphrase as spaced repetition training. Practice entering your passphrase <i>daily at first and then at least once a week</i> to commit it to memory.\n\nIt is essential to keep your passphrase safe. Do not re-use it for any other accounts. If you wrote it down, store it out of sight, in a secured location, away from your Bails USB sticks and destroy it once you memorize it." \ | |||
| --ok-label='I Will Destroy It Once Memorized' --width=640 $ICON | |||
| --text="You will be prompted to enter your passphrase as spaced repetition training.\n\nPractice entering your passphrase <i>daily at first and then at least once a week</i> to commit it to memory.\n | |||
There was a problem hiding this comment.
@epiccurious: review of this dialog text would be nice. I went Autistic on it. You can copy the code into Ubuntu terminal and it will mostly look the same as it would have in Tails if you don't have a VM open.
bin/persistent-setup
Outdated
| • locked desk drawer, or | ||
| • your wallet\nfor a few days, and destroy it once you know it well.\n | ||
| Write on a hard surface to avoid leaving an imprint of the secret.' \ | ||
| --ok-label='I Will Write My Passphrase Down' --icon-name=org.gnome.TextEditor |
There was a problem hiding this comment.
@epiccurious: This one is also changed but it's not as expansive. Mostly presenting bullet options of places to secure it since I found conflicting advice from reputable sources suggesting all 3 of these.
@epiccurious: I just tested it in my mind and it's passing. But you may want to read or launch the dialog text changes to make sure they're actually better than I looked at them too long to have a good opinion anymore. |
|
Branch will need a rebase to resolve the lint issues. |
The width was excessive in Tails 6.
I also made improvements to the text of a few.