-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Stats: Add Opens and Clicks tooltips #97729
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1003 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/my-sites/stats/features/modules/stats-emails/tooltips.tsx
Outdated
Show resolved
Hide resolved
client/my-sites/stats/features/modules/stats-emails/tooltips.tsx
Outdated
Show resolved
Hide resolved
client/my-sites/stats/features/modules/stats-emails/stats-emails.tsx
Outdated
Show resolved
Hide resolved
client/my-sites/stats/features/modules/stats-emails/stats-emails.tsx
Outdated
Show resolved
Hide resolved
Something is off with hovering: Screen.Recording.2024-12-27.at.15.52.22.movIn Chrome. |
Overall looking good! Missing unique clicks for some of our stats is worrying be quite a bit, and I had some small issues with hover causing flickering/tooltip not to show. |
I spent some time investigating this: #97638 (comment)
I couldn't reproduce after switching to |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17088699 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @lezama for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to #97638
Proposed Changes
This PR proposes rendering n/a when unique clicks data is unavailable (e.g., when we have clicks but not unique clicks data). It also adds tooltips to display subscribers reached, along with total and unique values.
Screen.Recording.2024-12-27.at.7.30.36.AM.mov
Why are these changes being made?
Testing Instructions
Pre-merge Checklist