Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpcom settings: Duplicate view pop up copy changes #41622

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Wpcom settings: Duplicate view pop up copy changes #41622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b50d0
Title updates
lsl Feb 7, 2025
2f6fb2f
Add Learn more link
lsl Feb 7, 2025
4995ded
changelog
lsl Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/jetpack-mu-wpcom/changelog/update-wpcom-settings-popup-copy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Updated copy on the wpcom duplicate view pop ups to include link to learn more.
43 changes: 19 additions & 24 deletions ...ges/jetpack-mu-wpcom/src/features/wpcom-admin-interface/removed-calypso-screen-notice.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ const Notice = () => {
},
'options-general.php': {
icon: settings,
title: hasTranslation( 'The General Settings view just got an update' )
? __( 'The General Settings view just got an update', 'jetpack-mu-wpcom' )
title: hasTranslation( 'General Settings just got an update' )
? __( 'General Settings just got an update', 'jetpack-mu-wpcom' )
: titleFallback,
description: hasTranslation(
"We've adopted WordPress' main General Settings view to bring improvements to you and millions of WordPress users worldwide."
Expand All @@ -162,8 +162,8 @@ const Notice = () => {
},
'options-writing.php': {
icon: verse,
title: hasTranslation( 'The Writing Settings view just got an update' )
? __( 'The Writing Settings view just got an update', 'jetpack-mu-wpcom' )
title: hasTranslation( 'Writing Settings just got an update' )
? __( 'Writing Settings just got an update', 'jetpack-mu-wpcom' )
: titleFallback,
description: hasTranslation(
"We've adopted WordPress' main Writing Settings view to bring improvements to you and millions of WordPress users worldwide."
Expand All @@ -176,8 +176,8 @@ const Notice = () => {
},
'options-reading.php': {
icon: page,
title: hasTranslation( 'The Reading Settings view just got an update' )
? __( 'The Reading Settings view just got an update', 'jetpack-mu-wpcom' )
title: hasTranslation( 'Reading Settings just got an update' )
? __( 'Reading Settings just got an update', 'jetpack-mu-wpcom' )
: titleFallback,
description: hasTranslation(
"We've adopted WordPress' main Reading Settings view to bring improvements to you and millions of WordPress users worldwide."
Expand All @@ -190,8 +190,8 @@ const Notice = () => {
},
'options-discussion.php': {
icon: postComments,
title: hasTranslation( 'The Discussion Settings view just got an update' )
? __( 'The Discussion Settings view just got an update', 'jetpack-mu-wpcom' )
title: hasTranslation( 'Discussion Settings just got an update' )
? __( 'Discussion Settings just got an update', 'jetpack-mu-wpcom' )
: titleFallback,
description: hasTranslation(
"We've adopted WordPress' main Discussion Settings view to bring improvements to you and millions of WordPress users worldwide."
Expand Down Expand Up @@ -223,20 +223,6 @@ const Notice = () => {
);
};

let title = sprintf(
// translators: %s: page name
__( 'The %s view just got better', 'jetpack-mu-wpcom' ),
removedCalypsoScreenNoticeConfig.title
);

if ( hasTranslation( 'The %s view just got an update' ) ) {
title = sprintf(
// translators: %s: page name
__( 'The %s view just got an update', 'jetpack-mu-wpcom' ),
removedCalypsoScreenNoticeConfig.title
);
}

return (
<Guide
className="removed-calypso-screen-notice"
Expand All @@ -255,8 +241,17 @@ const Notice = () => {
),
content: (
<>
<h1>{ title }</h1>
<p>{ config[ removedCalypsoScreenNoticeConfig.screen ].description }</p>
<h1>{ config[ removedCalypsoScreenNoticeConfig.screen ].title }</h1>
<p>
{ config[ removedCalypsoScreenNoticeConfig.screen ].description }&nbsp;
<a
href="https://wordpress.com/blog/2025/01/22/interface-update/"
target="_blank"
rel="noreferrer"
>
{ __( 'Learn more ↗', 'jetpack-mu-wpcom' ) }
</a>
</p>
</>
),
},
Expand Down
Loading