Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wpcom settings: Duplicate view pop up copy changes #41622

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Feb 7, 2025

Fixes Automattic/wp-calypso#99255

Before After
Screenshot 2025-02-07 at 17-11-41 General Settings ‹ Site Title — WordPress Screenshot 2025-02-07 at 17-11-08 General Settings ‹ Site Title — WordPress

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

# Build
jetpack build plugins/jetpack plugins/mu-wpcom-plugin packages/jetpack-mu-wpcom

# Sandbox
jetpack rsync mu-wpcom-plugin wpcom:~/public_html/wp-content/mu-plugins/jetpack-mu-wpcom-plugin/dev --watch

# Woa
jetpack rsync mu-wpcom-plugin woa:~/htdocs/wp-content/plugins/jetpack-mu-wpcom-plugin-dev --watch
  • Sandbox your test site domain
  • Assign yourself to the experiment 22129-explat-experiment
  • Site settings menu items should now be wp-admin versions
  • Note: you can use this line commented out to trigger the pop ups for testing.
  • Repeat test for atomic using Jetpack beta and applying the update/wpcom-duplicate-views-settings branch for WordPress.com Features

@lsl lsl self-assigned this Feb 7, 2025
@lsl lsl requested review from a team and matt-west February 7, 2025 06:13
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/wpcom-settings-popup-copy branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/wpcom-settings-popup-copy
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@lsl lsl changed the title Update/wpcom settings popup copy wpcom-mu-plugin: Duplicate view pop up copy changes Feb 7, 2025
@lsl lsl changed the title wpcom-mu-plugin: Duplicate view pop up copy changes Wpcom settings: Duplicate view pop up copy changes Feb 7, 2025
@okmttdhr okmttdhr merged commit 6c988c6 into trunk Feb 10, 2025
63 of 64 checks passed
@okmttdhr okmttdhr deleted the update/wpcom-settings-popup-copy branch February 10, 2025 02:57
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Update educational notices copy
2 participants