Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting promote video-stream-information to an applet #28780

Merged

Conversation

rmackay9
Copy link
Contributor

This enhances the set_VIDEO_STREAM_INFORMATION.lua to make it usable without any code changes by at least some users. The script is also promoted to an applet

The purpose of this script is to give the AP_Camera library the information it needs so that it can send VIDEO_STREAM_INFORMATION mavlink messages to the ground station so that it can display the live video stream to the user

15 new parameters have been added prefixed with VID1_ that allow the user to set nearly all fields of the VIDEO_STREAM_INFORMATION but for most users all they will only need to set these six:

  • VID1_CAMMODEL: Video stream camera model (1:Siyi A8, 2:Siyi ZR10, 3:Siyi ZR30, 4:Siyi ZT30 Zoom, 5:Siyi ZT30 Wide, 6:Siyi ZT30 IR, 7:Siyi ZT6 RGB, 8:Siyi ZT6 IR)
  • VID1_IPADDR0: Video stream IP Address first octet
  • VID1_IPADDR1: Video stream IP Address second octet
  • VID1_IPADDR2: Video stream IP Address third octet
  • VID1_IPADDR3: Video stream IP Address fourth octet
  • VID1_IPPORT: Video Stream IP Address Port

This has been successfully tested with the Siyi A8, ZR10 and ZT6 cameras and Mission Planner's new gimbal interface

Enhancements coming in future PRs:

  • default the IP address and Port to the camera defaults
  • add support for ViewPro, Topotek and any other Ethernet enabled camera gimbal

@rmackay9 rmackay9 dismissed Hwurzburg’s stale review December 4, 2024 04:17

HenryW's requests addressed, thanks for the review!

@rmackay9 rmackay9 force-pushed the scripting-video-stream-information-easy branch 2 times, most recently from 1924237 to 4ea1cf7 Compare December 4, 2024 04:52
@tridge tridge removed the DevCallEU label Dec 4, 2024
@rmackay9 rmackay9 force-pushed the scripting-video-stream-information-easy branch 3 times, most recently from 2bca955 to dd3e0f1 Compare December 4, 2024 11:48
@rmackay9 rmackay9 force-pushed the scripting-video-stream-information-easy branch from dd3e0f1 to c0ebf32 Compare December 5, 2024 01:49
@rmackay9
Copy link
Contributor Author

rmackay9 commented Dec 5, 2024

Since yesterday's review, I've also added support for Herelink, Topotek and ViewPro. During testing Topotek and ViewPro worked as expected but Herelink is giving some troubles. Still, unless there are objections I will merge this once it passes CI.

@rmackay9 rmackay9 merged commit 1308efb into ArduPilot:master Dec 5, 2024
100 checks passed
@rmackay9
Copy link
Contributor Author

rmackay9 commented Dec 5, 2024

FYI @nexton-winjeel

@rmackay9 rmackay9 deleted the scripting-video-stream-information-easy branch December 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4.6.0-beta2
Development

Successfully merging this pull request may close these issues.

4 participants