Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make typings more accurate by avoiding explict cast on consts #2475

Merged
merged 1 commit into from
Dec 2, 2024

fix: make typings more accurate by avoiding explict cast on consts

1603bff
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix: make typings more accurate by avoiding explict cast on consts #2475

fix: make typings more accurate by avoiding explict cast on consts
1603bff
Select commit
Loading
Failed to load commit list.
GitHub Actions / IT Tests report-windows-latest-npm succeeded Dec 2, 2024 in 1s

65 passed, 0 failed and 2 skipped

Tests passed successfully

Report Passed Failed Skipped Time
@ama-sdk/create/dist-test/it-report.xml 7✅ 967s
@ama-sdk/schematics/dist-test/it-report.xml 7ms
@o3r/analytics/dist-test/it-report.xml 2✅ 267s
@o3r/apis-manager/dist-test/it-report.xml 1✅ 120s
@o3r/application/dist-test/it-report.xml 1✅ 131s
@o3r/components/dist-test/it-report.xml 8✅ 859s
@o3r/configuration/dist-test/it-report.xml 2✅ 242s
@o3r/core/dist-test/it-report.xml 1✅ 663s
@o3r/create/dist-test/it-report.xml 3✅ 408s
@o3r/design/dist-test/it-report.xml 1✅ 121s
@o3r/eslint-config-otter/dist-test/it-report.xml 2✅ 244s
@o3r/eslint-config/dist-test/it-report.xml 3✅ 598s
@o3r/extractors/dist-test/it-report.xml 3✅ 425s
@o3r/localization/dist-test/it-report.xml 8✅ 1063s
@o3r/new-version/dist-test/it-report.xml 1✅ 101s
@o3r/pipeline/dist-test/it-report.xml 2✅ 148s
@o3r/rules-engine/dist-test/it-report.xml 2✅ 219s
@o3r/stylelint-plugin/dist-test/it-report.xml 2✅ 205s
@o3r/styling/dist-test/it-report.xml 8✅ 980s
@o3r/testing/dist-test/it-report.xml 2✅ 2⚪ 387s
@o3r/third-party/dist-test/it-report.xml 1✅ 119s
@o3r/workspace/dist-test/it-report.xml 5✅ 857s

✅ @ama-sdk/create/dist-test/it-report.xml

7 tests were completed in 967s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Create new sdk command 7✅ 954s

✅ Create new sdk command

Create new sdk command should generate a light SDK when the specification is provided
  ✅ Create new sdk command should generate a light SDK when the specification is provided
Create new sdk command should generate a full SDK when the specification is provided
  ✅ Create new sdk command should generate a full SDK when the specification is provided
Create new sdk command should generate a full SDK when the specification is provided as npm dependency
  ✅ Create new sdk command should generate a full SDK when the specification is provided as npm dependency
Create new sdk command should generate an SDK with no package scope
  ✅ Create new sdk command should generate an SDK with no package scope
Create new sdk command should generate an empty SDK ready to be used
  ✅ Create new sdk command should generate an empty SDK ready to be used
Create new sdk command should fail when there is an error
  ✅ Create new sdk command should fail when there is an error
Create new sdk command should use pinned versions when --exact-o3r-version is used
  ✅ Create new sdk command should use pinned versions when --exact-o3r-version is used

✅ @ama-sdk/schematics/dist-test/it-report.xml

No tests found

✅ @o3r/analytics/dist-test/it-report.xml

2 tests were completed in 267s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add analytics 2✅ 252s

✅ ng add analytics

ng add analytics should add analytics to an application
  ✅ ng add analytics should add analytics to an application
ng add analytics should add analytics to a library
  ✅ ng add analytics should add analytics to a library

✅ @o3r/apis-manager/dist-test/it-report.xml

1 tests were completed in 120s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with apis-manager 1✅ 105s

✅ new otter application with apis-manager

new otter application with apis-manager should add apis-manager to existing application
  ✅ new otter application with apis-manager should add apis-manager to existing application

✅ @o3r/application/dist-test/it-report.xml

1 tests were completed in 131s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new Angular application 1✅ 116s

✅ new Angular application

new Angular application should add Otter Application to existing Angular app
  ✅ new Angular application should add Otter Application to existing Angular app

✅ @o3r/components/dist-test/it-report.xml

8 tests were completed in 859s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 6✅ 840s
ng add components 2✅ 303s

✅ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ✅ check metadata migration should throw because no migration data
check metadata migration should throw because migration data invalid
  ✅ check metadata migration should throw because migration data invalid
check metadata migration should throw because breaking changes are not allowed
  ✅ check metadata migration should throw because breaking changes are not allowed
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add components

ng add components should add components to an application
  ✅ ng add components should add components to an application
ng add components should add components to a library
  ✅ ng add components should add components to a library

✅ @o3r/configuration/dist-test/it-report.xml

2 tests were completed in 242s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with configuration 2✅ 228s

✅ new otter application with configuration

new otter application with configuration should add configuration to an application
  ✅ new otter application with configuration should add configuration to an application
new otter application with configuration should add configuration to a library
  ✅ new otter application with configuration should add configuration to a library

✅ @o3r/core/dist-test/it-report.xml

1 tests were completed in 663s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application 1✅ 638s

✅ new otter application

new otter application should build empty app
  ✅ new otter application should build empty app

✅ @o3r/create/dist-test/it-report.xml

3 tests were completed in 408s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Create new otter project command 3✅ 397s

✅ Create new otter project command

Create new otter project command should generate a project with an application
  ✅ Create new otter project command should generate a project with an application
Create new otter project command should generate a project with a library
  ✅ Create new otter project command should generate a project with a library
Create new otter project command should generate a project with an application with --exact-o3r-version
  ✅ Create new otter project command should generate a project with an application with --exact-o3r-version

✅ @o3r/design/dist-test/it-report.xml

1 tests were completed in 121s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with Design 1✅ 104s

✅ new otter application with Design

new otter application with Design should add design to existing application
  ✅ new otter application with Design should add design to existing application

✅ @o3r/eslint-config-otter/dist-test/it-report.xml

2 tests were completed in 244s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add eslint-config 2✅ 231s

✅ ng add eslint-config

ng add eslint-config should add eslint-config to an application
  ✅ ng add eslint-config should add eslint-config to an application
ng add eslint-config should add eslint-config to a library
  ✅ ng add eslint-config should add eslint-config to a library

✅ @o3r/eslint-config/dist-test/it-report.xml

3 tests were completed in 598s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter application with eslint config 3✅ 576s

✅ new otter application with eslint config

new otter application with eslint config should add eslint config to existing application
  ✅ new otter application with eslint config should add eslint config to existing application
new otter application with eslint config should add eslint config to existing library
  ✅ new otter application with eslint config should add eslint config to existing library
new otter application with eslint config should add eslint config to existing repository
  ✅ new otter application with eslint config should add eslint config to existing repository

✅ @o3r/extractors/dist-test/it-report.xml

3 tests were completed in 425s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
aggregate migration scripts 1✅ 319s
ng add extractors 2✅ 403s

✅ aggregate migration scripts

aggregate migration scripts should create migration scripts including lib content
  ✅ aggregate migration scripts should create migration scripts including lib content

✅ ng add extractors

ng add extractors should add extractors to an application
  ✅ ng add extractors should add extractors to an application
ng add extractors should add extractors to a library
  ✅ ng add extractors should add extractors to a library

✅ @o3r/localization/dist-test/it-report.xml

8 tests were completed in 1063s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 6✅ 1045s
ng add otter localization 2✅ 357s

✅ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ✅ check metadata migration should throw because no migration data
check metadata migration should throw because migration data invalid
  ✅ check metadata migration should throw because migration data invalid
check metadata migration should throw because breaking changes are not allowed
  ✅ check metadata migration should throw because breaking changes are not allowed
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add otter localization

ng add otter localization should add localization to an application
  ✅ ng add otter localization should add localization to an application
ng add otter localization should add localization to a library
  ✅ ng add otter localization should add localization to a library

✅ @o3r/new-version/dist-test/it-report.xml

1 tests were completed in 101s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 88s

✅ undefined

 should add Otter Application to existing Angular app
  ✅ should add Otter Application to existing Angular app

✅ @o3r/pipeline/dist-test/it-report.xml

2 tests were completed in 148s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter project 2✅ 135s

✅ new otter project

new otter project should add a GitHub pipeline to existing project
  ✅ new otter project should add a GitHub pipeline to existing project
new otter project should add a GitHub pipeline to existing project with custom runner and registry
  ✅ new otter project should add a GitHub pipeline to existing project with custom runner and registry

✅ @o3r/rules-engine/dist-test/it-report.xml

2 tests were completed in 219s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add rules-engine 2✅ 204s

✅ ng add rules-engine

ng add rules-engine should add rules engine to an application
  ✅ ng add rules-engine should add rules engine to an application
ng add rules-engine should add rules engine to a library
  ✅ ng add rules-engine should add rules engine to a library

✅ @o3r/stylelint-plugin/dist-test/it-report.xml

2 tests were completed in 205s with 2 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng add stylelint-plugin 2✅ 194s

✅ ng add stylelint-plugin

ng add stylelint-plugin should add stylelint-plugin to an application
  ✅ ng add stylelint-plugin should add stylelint-plugin to an application
ng add stylelint-plugin should add stylelint-plugin to a library
  ✅ ng add stylelint-plugin should add stylelint-plugin to a library

✅ @o3r/styling/dist-test/it-report.xml

8 tests were completed in 980s with 8 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
check metadata migration 6✅ 961s
ng add styling 2✅ 356s

✅ check metadata migration

check metadata migration should not throw
  ✅ check metadata migration should not throw
check metadata migration should not throw on prerelease
  ✅ check metadata migration should not throw on prerelease
check metadata migration should throw because no migration data
  ✅ check metadata migration should throw because no migration data
check metadata migration should throw because migration data invalid
  ✅ check metadata migration should throw because migration data invalid
check metadata migration should throw because breaking changes are not allowed
  ✅ check metadata migration should throw because breaking changes are not allowed
check metadata migration should throw because of unused migration data
  ✅ check metadata migration should throw because of unused migration data

✅ ng add styling

ng add styling should add styling to an application
  ✅ ng add styling should add styling to an application
ng add styling should add styling to a library
  ✅ ng add styling should add styling to a library

✅ @o3r/testing/dist-test/it-report.xml

4 tests were completed in 387s with 2 passed, 0 failed and 2 skipped.

Test suite Passed Failed Skipped Time
ng add testing 2✅ 2⚪ 369s

✅ ng add testing

ng add testing should add testing to an application
  ✅ ng add testing should add testing to an application
ng add testing should add testing to an application and fixture to component
  ✅ ng add testing should add testing to an application and fixture to component
ng add testing should add testing to a library
  ⚪ ng add testing should add testing to a library
ng add testing should add testing to a library and fixture to component
  ⚪ ng add testing should add testing to a library and fixture to component

✅ @o3r/third-party/dist-test/it-report.xml

1 tests were completed in 119s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new Angular application 1✅ 103s

✅ new Angular application

new Angular application should add Otter Third Party to existing Angular app
  ✅ new Angular application should add Otter Third Party to existing Angular app

✅ @o3r/workspace/dist-test/it-report.xml

5 tests were completed in 857s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
new otter workspace 5✅ 844s

✅ new otter workspace

new otter workspace should add sdk to an existing workspace
  ✅ new otter workspace should add sdk to an existing workspace
new otter workspace should add sdk to an existing workspace with local spec
  ✅ new otter workspace should add sdk to an existing workspace with local spec
new otter workspace should add sdk to an existing workspace with spec package name
  ✅ new otter workspace should add sdk to an existing workspace with spec package name
new otter workspace should add a library to an existing workspace
  ✅ new otter workspace should add a library to an existing workspace
new otter workspace should generate a monorepo setup
  ✅ new otter workspace should generate a monorepo setup
View more details on GitHub Actions