-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make typings more accurate by avoiding explict cast on consts #2475
Open
kpanot
wants to merge
1
commit into
main
Choose a base branch
from
chore/more-precise-typings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Something isn't working
project:@ama-sdk/core
project:@ama-sdk/schematics
project:@ama-sdk/client-fetch
project:@ama-sdk/client-angular
project:@ama-sdk/client-beacon
project:@o3r/analytics
project:@o3r/application
project:@o3r/chrome-devtools
project:@o3r/core
project:@o3r/components
project:@o3r/configuration
project:@o3r/create
project:@o3r/dev-tools
project:@o3r/design
project:@o3r/dynamic-content
project:@o3r/extractors
project:@o3r/localization
project:@o3r/logger
project:@o3r/rules-engine
project:@o3r/schematics
project:@o3r/showcase
project:@o3r/styling
project:@o3r/testing
project:@o3r/test-helpers
project:@o3r/telemetry
project:@o3r/third-party
labels
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
fpaul-1A
approved these changes
Nov 15, 2024
sdo-1A
approved these changes
Nov 15, 2024
mrednic-1A
approved these changes
Nov 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
project:@ama-sdk/client-angular
project:@ama-sdk/client-beacon
project:@ama-sdk/client-fetch
project:@ama-sdk/core
project:@ama-sdk/schematics
project:new-version-gh-action
project:@o3r/analytics
project:@o3r/application
project:@o3r/chrome-devtools
project:@o3r/components
project:@o3r/configuration
project:@o3r/core
project:@o3r/create
project:@o3r/design
project:@o3r/dev-tools
project:@o3r/dynamic-content
project:@o3r/extractors
project:@o3r/localization
project:@o3r/logger
project:@o3r/rules-engine
project:@o3r/schematics
project:@o3r/showcase
project:@o3r/styling
project:@o3r/telemetry
project:@o3r/test-helpers
project:@o3r/testing
project:@o3r/third-party
project:@o3r/workspace
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When creating an object that is intended to be read-only, we should let typescript infer the type.
Not good:
Nice:
Related issues