Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make typings more accurate by avoiding explict cast on consts #2475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

fix: make typings more accurate by avoiding explict cast on consts

5108a4f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

fix: make typings more accurate by avoiding explict cast on consts #2475

fix: make typings more accurate by avoiding explict cast on consts
5108a4f
Select commit
Loading
Failed to load commit list.
GitHub Actions / UT Tests report-windows-latest succeeded Nov 15, 2024 in 0s

1310 passed, 0 failed and 11 skipped

Tests passed successfully

Report Passed Failed Skipped Time
apps/chrome-devtools/dist-test/junit.xml 1✅ 12s
apps/github-cascading-app/dist-test/junit.xml 19✅ 7s
apps/showcase/dist-test/junit.xml 27✅ 62s
apps/vscode-extension/dist-test/junit.xml 1✅ 537ms
packages/@ama-sdk/client-angular/dist-test/junit.xml 1✅ 5s
packages/@ama-sdk/client-beacon/dist-test/junit.xml 1✅ 4s
packages/@ama-sdk/client-fetch/dist-test/junit.xml 41✅ 20s
packages/@ama-sdk/core/dist-test/junit.xml 157✅ 33s
packages/@ama-sdk/schematics/dist-test/junit.xml 22✅ 49s
packages/@ama-terasu/cli/dist-test/junit.xml 1✅ 1s
packages/@ama-terasu/schematics/dist-test/junit.xml 1✅ 505ms
packages/@o3r-training/showcase-sdk/dist-test/junit.xml 4ms
packages/@o3r-training/training-tools/dist-test/junit.xml 1✅ 961ms
packages/@o3r/analytics/dist-test/junit.xml 42✅ 9⚪ 58s
packages/@o3r/apis-manager/dist-test/junit.xml 3✅ 5s
packages/@o3r/application/dist-test/junit.xml 1✅ 17s
packages/@o3r/artifactory-tools/dist-test/junit.xml 1✅ 1s
packages/@o3r/azure-tools/dist-test/junit.xml 1✅ 700ms
packages/@o3r/components/dist-test/junit.xml 73✅ 76s
packages/@o3r/configuration/dist-test/junit.xml 40✅ 58s
packages/@o3r/core/dist-test/junit.xml 118✅ 1⚪ 94s
packages/@o3r/design/dist-test/junit.xml 92✅ 34s
packages/@o3r/dev-tools/dist-test/junit.xml 3✅ 3s
packages/@o3r/dynamic-content/dist-test/junit.xml 64✅ 49s
packages/@o3r/eslint-config-otter/dist-test/junit.xml 3✅ 19s
packages/@o3r/extractors/dist-test/junit.xml 16✅ 40s
packages/@o3r/forms/dist-test/junit.xml 28✅ 19s
packages/@o3r/localization/dist-test/junit.xml 55✅ 90s
packages/@o3r/logger/dist-test/junit.xml 16✅ 25s
packages/@o3r/mobile/dist-test/junit.xml 6✅ 9s
packages/@o3r/new-version/dist-test/junit.xml 6✅ 9s
packages/@o3r/pipeline/dist-test/junit.xml 7✅ 12s
packages/@o3r/routing/dist-test/junit.xml 16✅ 25s
packages/@o3r/rules-engine/dist-test/junit.xml 258✅ 109s
packages/@o3r/schematics/dist-test/junit.xml 23✅ 23s
packages/@o3r/store-sync/dist-test/junit.xml 52✅ 19s
packages/@o3r/storybook/dist-test/junit.xml 23✅ 14s
packages/@o3r/stylelint-plugin/dist-test/junit.xml 4✅ 8s
packages/@o3r/styling/dist-test/junit.xml 31✅ 46s
packages/@o3r/telemetry/dist-test/junit.xml 16✅ 19s
packages/@o3r/test-helpers/dist-test/junit.xml 1✅ 4s
packages/@o3r/testing/dist-test/junit.xml 14✅ 43s
packages/@o3r/third-party/dist-test/junit.xml 9✅ 32s
packages/@o3r/workspace/dist-test/junit.xml 5✅ 1⚪ 27s
tools/github-actions/audit/dist-test/junit.xml 5✅ 3s
tools/github-actions/cascading/dist-test/junit.xml 4✅ 9s
tools/github-actions/new-version/dist-test/junit.xml 1✅ 637ms

✅ apps/chrome-devtools/dist-test/junit.xml

1 tests were completed in 12s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 10s

✅ apps/github-cascading-app/dist-test/junit.xml

19 tests were completed in 7s with 19 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Cascading Application 19✅ 7s

✅ apps/showcase/dist-test/junit.xml

27 tests were completed in 62s with 27 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
AppComponent 1✅ 6s
BasicPresComponent 1✅ 1s
ComponentReplacementComponent 1✅ 3s
ComponentReplacementPresComponent 1✅ 32s
ConfigurationComponent 1✅ 6s
ConfigurationPresComponent 1✅ 2s
CopyTextPresComponent 1✅ 675ms
DatePickerHebrewInputPresComponent 1✅ 2s
DatePickerInputPresComponent 1✅ 2s
DesignTokenComponent 1✅ 2s
DesignTokenPresComponent 1✅ 2s
DynamicContentComponent 1✅ 5s
DynamicContentPresComponent 1✅ 2s
HomeComponent 1✅ 2s
InPageNavPresComponent 1✅ 1s
LocalizationComponent 1✅ 5s
LocalizationPresComponent 1✅ 4s
OtterPickerPresComponent 1✅ 1s
PlaceholderComponent 1✅ 4s
PlaceholderPresComponent 1✅ 2s
RulesEngineComponent 1✅ 39s
RulesEnginePresComponent 1✅ 31s
RunAppLocallyComponent 1✅ 2s
ScrollBackTopPresComponent 1✅ 735ms
SdkComponent 1✅ 4s
SdkPresComponent 1✅ 2s
SidenavPresComponent 1✅ 2s

✅ apps/vscode-extension/dist-test/junit.xml

1 tests were completed in 537ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 388ms

✅ packages/@ama-sdk/client-angular/dist-test/junit.xml

1 tests were completed in 5s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 4s

✅ packages/@ama-sdk/client-beacon/dist-test/junit.xml

1 tests were completed in 4s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 3s

✅ packages/@ama-sdk/client-fetch/dist-test/junit.xml

41 tests were completed in 20s with 41 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Abort Plugin 3✅ 440ms
Concurrent Fetch Plugin 3✅ 2s
Keepalive Request Plugin 1✅ 421ms
Mock intercept 7✅ 14s
PerformanceMetricPlugin 4✅ 1s
Retry Fetch Plugin 6✅ 13s
Timeout Fetch Plugin 11✅ 14s
Wait For Fetch Plugin 6✅ 1s

✅ packages/@ama-sdk/core/dist-test/junit.xml

157 tests were completed in 33s with 157 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Abort Plugin 3✅ 209ms
Additional Params Request Plugin 6✅ 343ms
Api Key Request Plugin 6✅ 319ms
Api Key Request Plugin 2✅ 325ms
ApiConfigurationOverride Plugin 3✅ 429ms
BotProtectionFingerprint 12✅ 11s
Client Facts request plugin 8✅ 2s
Concurrent Fetch Plugin 3✅ 716ms
Custom info reply plugin 4✅ 569ms
DateTime 13✅ 247ms
Exception Reply Plugin 5✅ 491ms
Fetch API cache Request Plugin 3✅ 295ms
Fetch API credentials Request Plugin 2✅ 218ms
getResponseReviver - revivers by status code 8✅ 5s
JSON auth token request plugin 6✅ 2s
Json Token 3✅ 1s
JSON token utils 3✅ 1s
Keepalive Request Plugin 1✅ 206ms
Mock intercept 7✅ 4s
Ng add @ama-sdk/core 1✅ 12s
PerformanceMetricPlugin 4✅ 335ms
Raw response info Reply plugin 4✅ 247ms
Retry Fetch Plugin 6✅ 317ms
Reviver Reply Plugin 3✅ 224ms
Revivers : 4✅ 213ms
Session ID Request Plugin 6✅ 294ms
SI Token Request Plugin 1✅ 235ms
Timeout Fetch Plugin 11✅ 11s
Tokenizer Request Plugin 11✅ 13s
URL Rewrite Request Plugin 2✅ 233ms
Wait For Fetch Plugin 6✅ 853ms

✅ packages/@ama-sdk/schematics/dist-test/junit.xml

22 tests were completed in 49s with 22 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
generateOperationFinderFromSingleFile 3✅ 12s
Java Core Generator 1✅ 3s
Ng add 1✅ 2s
Specs processing 2✅ 27s
Typescript Core Generator 5✅ 38s
Typescript Shell Generator 10✅ 41s

✅ packages/@ama-terasu/cli/dist-test/junit.xml

1 tests were completed in 1s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 907ms

✅ packages/@ama-terasu/schematics/dist-test/junit.xml

1 tests were completed in 505ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 372ms

✅ packages/@o3r-training/showcase-sdk/dist-test/junit.xml

No tests found

✅ packages/@o3r-training/training-tools/dist-test/junit.xml

1 tests were completed in 961ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Otter Training WebContainer 1✅ 731ms

✅ packages/@o3r/analytics/dist-test/junit.xml

51 tests were completed in 58s with 42 passed, 0 failed and 9 skipped.

Test suite Passed Failed Skipped Time
Add Analytics 5✅ 30s
EventTrack Selectors tests 3✅ 2s
EventTrack Store reducer 13✅ 33s
Performance metrics 7✅ 9⚪ 49s
Track click directive: 5✅ 5s
Track events directive: 4✅ 3s
Track focus directive: 5✅ 14s

✅ packages/@o3r/apis-manager/dist-test/junit.xml

3 tests were completed in 5s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
appendPreconnect 3✅ 3s

✅ packages/@o3r/application/dist-test/junit.xml

1 tests were completed in 17s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 14s

✅ packages/@o3r/artifactory-tools/dist-test/junit.xml

1 tests were completed in 1s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 925ms

✅ packages/@o3r/azure-tools/dist-test/junit.xml

1 tests were completed in 700ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 549ms

✅ packages/@o3r/components/dist-test/junit.xml

73 tests were completed in 76s with 73 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
CapitalizePipe 4✅ 491ms
Component Extractor Builder 1✅ 31s
DurationPipe 14✅ 2s
Keep white space pipe 3✅ 967ms
Otter inspector helpers 7✅ 5s
Otter Inspector Service 4✅ 2s
Placeholder component 4✅ 23s
PlaceholderRequest Selectors tests 2✅ 568ms
PlaceholderRequest Store reducer 7✅ 1s
PlaceholderTemplate Store reducer 3✅ 918ms
Rendering helpers 4✅ 928ms
Replace with bold pipe 7✅ 1s
Rules Engine Effects 6✅ 32s
selectPlaceholderRenderedTemplates 4✅ 22s
Update v10 3✅ 14s

✅ packages/@o3r/configuration/dist-test/junit.xml

40 tests were completed in 58s with 40 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Config 7✅ 33s
ConfigOverride Store reducer 2✅ 881ms
Configuration DevTools console 5✅ 8s
Configuration DevTools message 3✅ 1s
Configuration operators getConfiguration 2✅ 679ms
Configuration Store 8✅ 31s
ConfigurationBaseService 10✅ 36s
Migrate to config signal-based 1✅ 10s
Update 2✅ 8s

✅ packages/@o3r/core/dist-test/junit.xml

119 tests were completed in 94s with 118 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
Add context 5✅ 20s
App version Builder 1✅ 7s
AsyncOperator 1✅ 10s
AsyncStoreItemAdapter tests 22✅ 21s
Component container 11✅ 44s
Component presenter 13✅ 71s
Convert component generator 3✅ 8s
createEntityAsyncRequestAdapter tests 16✅ 23s
debug helper 4✅ 2s
Deep fill function 16✅ 2s
Page 11✅ 15s
Pattern replacement Builder 1✅ 3s
Rendering helpers 4✅ 2s
Renovate Bot generator 1✅ 3s
Service generator 2✅ 1⚪ 3s
Store Action generator 1✅ 3s
Store entity async generator 2✅ 4s
Store entity sync generator 1✅ 4s
Store simple async generator 1✅ 3s
Store simple sync generator 1✅ 3s
Update component decorators 1✅ 3s

✅ packages/@o3r/design/dist-test/junit.xml

92 tests were completed in 34s with 92 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Design Token to component 3✅ 18s
Design Token generator 6✅ 13s
Design Token Parser 13✅ 10s
Design Token Renderer 14✅ 11s
Extract Token schematic 3✅ 22s
getCssStyleContentUpdater 3✅ 248ms
getCssTokenValueRenderer 7✅ 822ms
getDesignTokenStyleContentUpdater 2✅ 529ms
getDesignTokenTokenDefinitionRenderer 5✅ 582ms
getDesignTokenTokenValueRenderer 3✅ 271ms
getJsonSchemaStyleContentUpdater 1✅ 237ms
getJsonSchemaTokenValueRenderer 2✅ 836ms
getMetadataStyleContentUpdater 1✅ 745ms
getMetadataTokenDefinitionRenderer 4✅ 610ms
getMetadataTokenDefinitionRenderer 3✅ 265ms
getMetadataTokenDefinitionRenderer 2✅ 470ms
getMetadataTokenValueRenderer 3✅ 1s
getSassTokenDefinitionRenderer 3✅ 365ms
getSassTokenValueRenderer 7✅ 395ms
isO3rPrivateVariable 3✅ 492ms
mergeDesignTokenTemplates function 2✅ 246ms
ng-add 2✅ 13s

✅ packages/@o3r/dev-tools/dist-test/junit.xml

3 tests were completed in 3s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
String utils 3✅ 3s

✅ packages/@o3r/dynamic-content/dist-test/junit.xml

64 tests were completed in 49s with 64 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
AssetPathOverride Store reducer 2✅ 3s
DynamicContentPipe 1✅ 14s
DynamicContentService 18✅ 36s
RequestParametersService 41✅ 34s
Update v10 2✅ 24s

✅ packages/@o3r/eslint-config-otter/dist-test/junit.xml

3 tests were completed in 19s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Generate linter files 3✅ 18s

✅ packages/@o3r/extractors/dist-test/junit.xml

16 tests were completed in 40s with 16 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Aggregate migration scripts 3✅ 36s
config doc 5✅ 14s
metadata files helpers 6✅ 36s
Update categories in configuration extractor 2✅ 12s

✅ packages/@o3r/forms/dist-test/junit.xml

28 tests were completed in 19s with 28 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Form helpers 15✅ 10s
FormErrorMessages Selectors 2✅ 10s
FormErrorMessages Store reducer 7✅ 8s
Max Date 2✅ 4s
Min Date 2✅ 5s

✅ packages/@o3r/localization/dist-test/junit.xml

55 tests were completed in 90s with 55 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Localization 6✅ 39s
Add Localization 6✅ 4s
Localization builder 3✅ 11s
Localization Builder 1✅ 22s
Localization DevTools console 1✅ 3s
Localization Extractor Builder 1✅ 23s
Localization i18n Builder 1✅ 12s
LocalizationOverride Store reducer 2✅ 729ms
LocalizationService 10✅ 49s
LocalizationTranslatePipe 5✅ 9s
LocalizedCurrencyPipe 2✅ 3s
LocalizedDatePipe 2✅ 1s
LocalizedDecimalPipe 2✅ 1s
TranslationsLoader - no endPointUrl 11✅ 47s
Update v10 2✅ 11s

✅ packages/@o3r/logger/dist-test/junit.xml

16 tests were completed in 25s with 16 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Logger service 16✅ 20s

✅ packages/@o3r/mobile/dist-test/junit.xml

6 tests were completed in 9s with 6 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Capacitor helpers 6✅ 6s

✅ packages/@o3r/new-version/dist-test/junit.xml

6 tests were completed in 9s with 6 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
helpers 1✅ 5s
New Version 5✅ 7s

✅ packages/@o3r/pipeline/dist-test/junit.xml

7 tests were completed in 12s with 7 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
ng-add 7✅ 12s

✅ packages/@o3r/routing/dist-test/junit.xml

16 tests were completed in 25s with 16 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Routing guard effects 3✅ 15s
RoutingGuard Selectors tests 5✅ 14s
RoutingGuard Store reducer 8✅ 13s

✅ packages/@o3r/rules-engine/dist-test/junit.xml

258 tests were completed in 109s with 258 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Array based operator 86✅ 31s
Basic operator 23✅ 2s
Enable rules-engine on component 4✅ 57s
Filter rulesets event operator 5✅ 1s
Generate facts service 1✅ 7s
Generate operator 2✅ 24s
Number based operator 12✅ 2s
O3rJsonOrStringPipe 2✅ 750ms
Operator helpers 16✅ 3s
Operators 32✅ 35s
Rule helpers 13✅ 1s
Rules engine debug 5✅ 6s
Rules engine debug helpers 6✅ 1s
Rules Engine DevTools console 1✅ 3s
Rules Engine Effects 1✅ 1s
Rules engine fact 2✅ 851ms
Rules engine service 15✅ 44s
Rules-engine Extractor Builder 1✅ 35s
RuleSets Selector tests 13✅ 5s
Rulesets Store reducer 13✅ 2s
Rx Rule Engine 5✅ 776ms

✅ packages/@o3r/schematics/dist-test/junit.xml

23 tests were completed in 23s with 23 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
addVsCodeRecommendations 3✅ 2s
Devtools Registration 6✅ 19s
Get schematics options 5✅ 10s
getMigrationRuleRunner 3✅ 1s
ignorePatterns 3✅ 1s
updateImportsInFile 3✅ 20s

✅ packages/@o3r/store-sync/dist-test/junit.xml

52 tests were completed in 19s with 52 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Deep fill function 12✅ 14s
ngrxLocalStorage 40✅ 10s

✅ packages/@o3r/storybook/dist-test/junit.xml

23 tests were completed in 14s with 23 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Configuration Metadata setup 5✅ 8s
generateThemeCss 2✅ 6s
generateThemeCss 2✅ 378ms
Localization Metadata setup 4✅ 5s
Styling Metadata setup 10✅ 9s

✅ packages/@o3r/stylelint-plugin/dist-test/junit.xml

4 tests were completed in 8s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
o3r-var-parameter-equal-variable 4✅ 8s

✅ packages/@o3r/styling/dist-test/junit.xml

31 tests were completed in 46s with 31 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Theming 2✅ 15s
CSS Variable extractor 2✅ 16s
Styling Extractor Builder 1✅ 24s
Theming functions 2✅ 853ms
Theming functions 2✅ 2s
Theming mixins 3✅ 5s
Theming mixins 3✅ 1s
Update Styling imports 1✅ 3s
Update v10 7✅ 26s
Utils function 4✅ 13s
Utils function 4✅ 10s

✅ packages/@o3r/telemetry/dist-test/junit.xml

16 tests were completed in 19s with 16 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Builder with metrics 4✅ 13s
CLI with metrics 7✅ 12s
createSchematicWithMetricsIfInstalled 4✅ 12s
Update v11.3 1✅ 5s

✅ packages/@o3r/test-helpers/dist-test/junit.xml

1 tests were completed in 4s with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 4s

✅ packages/@o3r/testing/dist-test/junit.xml

14 tests were completed in 43s with 14 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Fixture 5✅ 37s
Fixture 2✅ 5s
Localization mocks imports 1✅ 3s
Playwright Sanity 2✅ 25s
Playwright Scenario 2✅ 26s
Update ThrowOnUndefined helper 2✅ 4s

✅ packages/@o3r/third-party/dist-test/junit.xml

9 tests were completed in 32s with 9 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
A/B testing bridge 3✅ 23s
Add Iframe 5✅ 25s
third party integration 1✅ 21s

✅ packages/@o3r/workspace/dist-test/junit.xml

6 tests were completed in 27s with 5 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
generateApplication 4✅ 17s
New module generator 1✅ 1⚪ 24s

✅ tools/github-actions/audit/dist-test/junit.xml

5 tests were completed in 3s with 5 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
github-action audit 5✅ 3s

✅ tools/github-actions/cascading/dist-test/junit.xml

4 tests were completed in 9s with 4 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
helpers 4✅ 9s

✅ tools/github-actions/new-version/dist-test/junit.xml

1 tests were completed in 637ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 480ms