-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataset_states_to_obs.py with camera depths #99
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! These changes might work for robosuite v1.3+ but it would break backwards compatibility with earlier versions of robosuite, which is needed for datasets like this one. We will work on a more comprehensive PR ourselves and integrate the functionality once it is ready.
The point cloud visualization looks nice though - do you have a script for that as well? We could consider integrating it, or providing a modified version of it as an example |
Sure! Here is the python script. It might need more cleanup.
|
Thank you! Also the PR for robosuite depth observation support is up - please feel free to test it and let us know if it works for you. #104 |
As discussed in Issue #98, I created a PR, which enables extracting depth from the demo. In addition, I added camera extrinsic and intrinsic information so that we could retrieve the point cloud. The aggregated point cloud is shown here.
Since I do not have a very deep understanding of robomimic, I am not 100% sure whether my implementation will break other things. So feel free to point out my mistakes!