Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the comment on 'pasp' forward #2528

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/write.c
Original file line number Diff line number Diff line change
Expand Up @@ -3037,11 +3037,12 @@ static avifResult avifRWStreamWriteProperties(avifItemPropertyDedup * const dedu
AVIF_RESULT_NOT_IMPLEMENTED);
}

// Based on the explanation above, 'clap', 'irot' and 'imir' have to match between the base and
// gain map image items in the container part of the encoded file.
// 'pasp' is not a transformative property (despite AVIF_TRANSFORM_PASP being part of
// avifTransformFlag) but it is assumed to apply to the gain map in the same way as
// the transformative properties above.

// Based on the explanation above, 'clap', 'irot', 'imir' and 'pasp' have to match between the base and
// gain map image items in the container part of the encoded file.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I also added 'pasp' to line 3044.

// To enforce that, the transformative and 'pasp' properties of the gain map cannot be set explicitly in the API.
AVIF_CHECKERR(itemMetadata->transformFlags == AVIF_TRANSFORM_NONE, AVIF_RESULT_ENCODE_GAIN_MAP_FAILED);
AVIF_CHECKRES(avifEncoderWriteTransformativeProperties(&dedup->s, s, imageMetadata, &item->ipma, dedup));
Expand Down
Loading