Move the comment on 'pasp' forward #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added to the middle of a paragraph. It should go before that paragraph.
wantehchang
commented
Dec 20, 2024
| // 'pasp' is not a transformative property (despite AVIF_TRANSFORM_PASP being part of | ||
| // avifTransformFlag) but it is assumed to apply to the gain map in the same way as | ||
| // the transformative properties above. | ||
|
|
||
| // Based on the explanation above, 'clap', 'irot', 'imir' and 'pasp' have to match between the base and | ||
| // gain map image items in the container part of the encoded file. |
There was a problem hiding this comment.
Note that I also added 'pasp' to line 3044.
y-guyon
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added to the middle of a paragraph. It should go before that paragraph.