-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Supprime la phrase sur les 120 pix professionalisants sur les certificats v3 (PIX-15161) #10499
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-15161-suppress-professionalization-warning
Nov 8, 2024
Merged
[FEATURE] Supprime la phrase sur les 120 pix professionalisants sur les certificats v3 (PIX-15161) #10499
pix-service-auto-merge
merged 3 commits into
dev
from
pix-15161-suppress-professionalization-warning
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
HEYGUL
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
from
November 6, 2024 15:05
eb0d1fa
to
7881294
Compare
HEYGUL
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
from
November 7, 2024 09:10
56800e4
to
2953ed1
Compare
P-Jeremy
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
4 times, most recently
from
November 7, 2024 14:46
dc75db6
to
d5b2e1b
Compare
AndreiaPena
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
from
November 8, 2024 09:44
d5b2e1b
to
b657a0c
Compare
AndreiaPena
reviewed
Nov 8, 2024
...certification/results/integration/infrastructure/repositories/certificate-repository_test.js
Outdated
Show resolved
Hide resolved
AndreiaPena
reviewed
Nov 8, 2024
...certification/results/integration/infrastructure/repositories/certificate-repository_test.js
Outdated
Show resolved
Hide resolved
AndreiaPena
reviewed
Nov 8, 2024
AndreiaPena
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testé !
AndreiaPena
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
from
November 8, 2024 10:12
b657a0c
to
f698365
Compare
AndreiaPena
added
🚀 Ready to Merge
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Nov 8, 2024
Co-authored-by: Guillaume LAGORCE <[email protected]>
pix-service-auto-merge
force-pushed
the
pix-15161-suppress-professionalization-warning
branch
from
November 8, 2024 10:13
f698365
to
0371179
Compare
pix-service-auto-merge
deleted the
pix-15161-suppress-professionalization-warning
branch
November 8, 2024 10:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
L’ancien certificat/certificat partagé/attestation comporte la mention “Le certificat Pix est reconnu comme professionnalisant par France compétences à compter d’un score minimal de 120 pix”, ce qui n’est plus vrai pour la nouvelle Certification.
🌰 Proposition
Conditionner l'affichage de la mention aux seuls certificats v2.
Pour cela on ajoute la version du
session
dans leShareableCertificate
.🪵 Pour tester
Utiliser la page
/verification-certificat
pour un certificat v2.Constater la présence de la mention sur la professionnalisation.
Utiliser la page
/verification-certificat
pour un certificat v3.Constater l'absence de la mention sur la professionnalisation.
Effectuer les mêmes tests pour le certificat privé