-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Ne pas afficher la mention professionnalisante sur le PDF de l'attestation d'une certification v3 (PIX-15163). #10508
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
Nov 14, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
AndreiaPena
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
2 times, most recently
from
November 8, 2024 10:48
2cec9c1
to
5eaa213
Compare
AndreiaPena
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
from
November 12, 2024 16:33
153cd77
to
dad14f6
Compare
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
AndreiaPena
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
from
November 13, 2024 09:02
dad14f6
to
3de3f6b
Compare
AndreiaPena
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
Nov 14, 2024
HEYGUL
reviewed
Nov 14, 2024
api/src/certification/results/infrastructure/utils/pdf/AttestationViewModel.js
Outdated
Show resolved
Hide resolved
HEYGUL
approved these changes
Nov 14, 2024
alexandrecoin
approved these changes
Nov 14, 2024
HEYGUL
added
Func Review OK
PO validated functionally the PR
and removed
👀 Func Review Needed
labels
Nov 14, 2024
P-Jeremy
approved these changes
Nov 14, 2024
AndreiaPena
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
from
November 14, 2024 14:22
3de3f6b
to
3b1c69f
Compare
pix-service-auto-merge
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
from
November 14, 2024 14:48
3b1c69f
to
cf16aef
Compare
pix-service-auto-merge
force-pushed
the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
from
November 14, 2024 14:55
cf16aef
to
04a2ccf
Compare
pix-service-auto-merge
deleted the
pix-15163-remove-professionalizing-certification-message-on-v3-pdf-attestations
branch
November 14, 2024 15:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
L’ancien certificat/certificat partagé/attestation comporte la mention “Le certificat Pix est reconnu comme professionnalisant par France compétences à compter d’un score minimal de 120 pix”, ce qui n’est plus vrai pour la nouvelle Certification.
🌰 Proposition
Conditionner l'affichage de la mention aux seuls certificats v2.
Pour cela on ajoute la version de la session
🎃 Remarques
Suite de la PR #10499
🪵 Pour tester
V3 (SCO):
Coté Admin
V2 à date professionnalisante :
Coté App
V2 à date professionnalisante :
version SCO = [email protected]
Coté Orga
La première attestation => pas de mention PRO, c'est une session V3 faite par First-name0
Les autres sont des v2 => mention si date pro